864329 - no error message when password for account becomes incorrect

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::Calendar, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I changed the password for an account that I had set up in the Firefox OS calendar client.  When I start the calendar client (which now no longer has the correct password), I don't get any UI telling me that the calendar client is no longer able to sync my calendar.  I should get some sort of UI telling me the password is wrong and preferably leading me to enter the correct password.

Steps to reproduce:
 1. set up an calendar account and sync it successfully
 2. change the password for that account
 3. start the calendar app

Actual results: nothing

Expected results: error, preferably leading me to enter the password

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Oops, should have mentioned I'm on a self-built v1-train build built a few hours ago, on an Otoro.

Comment 2

[James Lal [:lightsofapollo]]

Hmm... When the CalDAV provider fails to sync we should send some kind of message to allow the user to update their password. Email has an existing flow for this kind of thing we can copy.

Comment 3

[Stephany Wilkes]

Flagging Francis for UX in the form of the sync failure message (a string the user sees). Hopefully we can re-use the the email string referenced in comment 2.

Comment 4

[Lukas Blakk [:lsblakk] use ?needinfo]

Unfortunate user confusion, but not a blocker for v1.0.1 - putting back to leo? so we can look at pushing this into v1.1

Comment 5

[Wayne Chang [:wchang]]

Triage 4/29 - do not block release with this, but track and take if approved.
Leaving UX-P, UX to please renom this if this is seen as must have for v1.1.

Comment 6

[Francis Djabri [:djabber]]

Attachment: error message

This looks serious to me. The consequences are far worse than just user confusion - the user will have incorrect data and will have no way of knowing about it. This could lead to the user missing appointments, which could potentially be very damaging both to the user and to our reputation. 

I suggest that an error page is displayed to the user, using the similar form used by email to inform the user of a similar error - see attached.

Comment 7

[Stephany Wilkes]

Clearing UX-P? as Francis provided a UX recommendation.

Comment 8

[James Lal [:lightsofapollo]]

See also: https://bugzilla.mozilla.org/show_bug.cgi?id=870664

Might need UX improvements as this is primarily designed for OAuth2 flows but works for traditional (your Mozilla calendar, yahoo, normal caldav) flows too.

Comment 9

[Jason Smith [:jsmith]]

Tested out after bug 867748 landed - this definitely isn't fixed.

Comment 10

[James Lal [:lightsofapollo]]

Hmm- This should definitely be fixed in master (tchung saw the error message) we have the overlay popup bug which makes this less clear. Can you provide some more details?

The important bit is we don't check on startup only when the user tries to interact with the server (edit account / sync / add event, etc..)

Comment 11

[Jason Smith [:jsmith]]

I'm seeing the popup bug occurring, but I quickly dismiss it, I don't see an error showing up indicating that the password is incorrect.

Comment 12

[James Lal [:lightsofapollo]]

Jason says it works for him.