Hold on to a SelfReference for ScriptProcessorNodes which do not have an input

RESOLVED FIXED in mozilla23

Status

()

Core
Web Audio
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Away for a while, Assigned: Away for a while)

Tracking

Trunk
mozilla23
x86
Mac OS X
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
These nodes will act as source nodes, so we need to make sure we keep them alive while they're producing output.
(Assignee)

Comment 1

5 years ago
Created attachment 740587 [details] [diff] [review]
Patch (v1)
Assignee: nobody → ehsan
Status: NEW → ASSIGNED
Attachment #740587 - Flags: review?(paul)

Updated

5 years ago
Attachment #740587 - Flags: review?(paul) → review+
        // Two arrays containing all the PannerNodes and AudioBufferSourceNodes,
        // to compute the doppler shift. Those are weak pointers.

You should fix that comment.

Also, these should be hash-sets, not arrays, otherwise we could have pathological behavior for very large graphs when nodes are added and removed a lot.
https://hg.mozilla.org/mozilla-central/rev/13aa5e23f951
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
(Assignee)

Comment 5

5 years ago
(In reply to Robert O'Callahan (:roc) (Mozilla Corporation) from comment #3)
>         // Two arrays containing all the PannerNodes and
> AudioBufferSourceNodes,
>         // to compute the doppler shift. Those are weak pointers.
> 
> You should fix that comment.
> 
> Also, these should be hash-sets, not arrays, otherwise we could have
> pathological behavior for very large graphs when nodes are added and removed
> a lot.

Filed bug 865548 for this.
(Assignee)

Comment 6

5 years ago
Mass moving Web Audio bugs to the Web Audio component.  Filter on duckityduck.
Component: Video/Audio → Web Audio
You need to log in before you can comment on or make changes to this bug.