864363 - ProfileManager calls into nsWindowWatcher without having initialized nsContentUtils

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Bobby Holley (:bholley)]

This is the issue from bug 863646, which is now closed, because we fixed the startup crash with a backout of bug 860438. But we still need to fix this.

Comment 1

[Bobby Holley (:bholley)]

https://tbpl.mozilla.org/?tree=Try&rev=145fe1235ad6

Comment 2

[Andrew McCreight [:mccr8]]

I wonder if this is related to the shutdown leaks I see from running the profile manager.

Comment 3

[Bobby Holley (:bholley)]

Attachment: Force layout initialization in XPCOM initialization. r=bsmedberg

This patch was r+-ed on the other bug.

Comment 4

[Bobby Holley (:bholley)]

Attachment: Fix standalone unit test to use the JSRuntime from XPConnect. v1

It turns out that the JS engine asserts that we only ever have one JSRuntime
per thread. So when we spin up XPConnect in XPCOM initialization, we run into
assertions when this standalone test does JS_NewRuntime. FWIW, it probably
shouldn't be creating a random runtime and then passing that cx into Gecko
APIs anyway.

It sure would be nice if C++ unit tests could run with internal linkage... :-(

Comment 5

[Benjamin Smedberg]

Comment on attachment 740392 [details] [diff] [review]
Fix standalone unit test to use the JSRuntime from XPConnect. v1

You could just make this a gtest...

Comment 6

[Bobby Holley (:bholley)]

Green on try:

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/86983e77d4a5
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/756245b309a2

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/86983e77d4a5
https://hg.mozilla.org/mozilla-central/rev/756245b309a2