86439 - emoticon images cannot be seen by email recipient

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Anatoliy Averbukh]

If reciepient gets email content with emoticons (sent as HTML), the emoticons 
cannot be seen as images, just as text code.

Comment 1

[Anatoliy Averbukh]

Attachment: patch

Comment 2

[Jean-Francois Ducarroz]

R=ducarroz

Comment 3

[Anatoliy Averbukh]

Attachment: images

Comment 4

[Anatoliy Averbukh]

Currently the images are the same for both classic and modern.

Comment 5

[(not reading, please use [e-mail] instead)]

please attach a cvs diff of mozilla/themes directory.

from my bugscape comments:

it looks like you plan on having the same icons in the tree twice:

once as editor content (these are not skinnable?) and again as part of the 
mailnews skin.  

Anatoliy mentioned that (according to German), the images in editor will not be 
skinnable and the ones for chat, AIM and mailnews will be skinnable.

how many places to we plan on having the same icons?  shouldn't they be in a 
common place?  if the skinable images are shared by editor, chatzilla, mail, and
AIM, shouldn't they be in xpfe global?  you'd want the same images across all
applications, right?

Comment 6

[Anatoliy Averbukh]

Seth, you are right. xpfe/global is a nice place.
Creating new attachment.

Comment 7

[Anatoliy Averbukh]

Attachment: new patch

Comment 8

[Blake Ross]

If you put them in xpfe/global, they're not skinnable.  These should be in 
themes/[theme-name]/communicator.  I don't think we currently have a place for 
icons that are the same for both modern and classic.

Comment 9

[timeless]

If the theme selects the image using css couldn't it easily select one from 
chrome://editor/content/default-happy-icon.gif
or chrome://editor/skin/happy-icon-spoof.gif ?

Comment 10

[(not reading, please use [e-mail] instead)]

I said xpfe/global, I but I meant:

mozilla/themes/modern/global/icons/*.gif would be the right place (so they'd be
modern.jar)

[for classic, probably mozilla/themes/classic/global/*.gif] so they'd be in
classic.jar

these should not be in content, they should be in the skin as they are skinable.

Comment 11

[Blake Ross]

Generally /communicator is for things useful only within the Mozilla suite, 
while things in /global would be useful for any app. I guess these would fall 
under the latter, so what seth said sounds good to me.

Comment 12

[Anatoliy Averbukh]

Attachment: moving to skin

Comment 13

[Anatoliy Averbukh]

Attachment: adding full patch

Comment 14

[(not reading, please use [e-mail] instead)]

sr=sspitzer

Comment 15

[(not reading, please use [e-mail] instead)]

I'm going to open up a new bug on all the cruft in the tree.

the icons should be in the tree once (per skin, and not in content) and all the 
references to them should be fixed.

Comment 16

[(not reading, please use [e-mail] instead)]

cruft bug logged: #86691

Comment 17

[Joe Hewitt (gone)]

Anatoliy, please create a new folder in global called "smiley" and place all of
the smiley gifs in there.  We try to keep all of our global images organized
like that.

Comment 18

[Anatoliy Averbukh]

Joe, yes, will create new folder under global

Comment 19

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Could you clarify what exactly is being changed here?  Is there a change in the
message that is sent over the wire, the way Mozilla views messages it recieves,
or both?  What changes are made to each?

Comment 20

[(not reading, please use [e-mail] instead)]

still waiting for a new patch that puts the new icons in a subdirectory, like
hewitt suggested.

Comment 21

[Anatoliy Averbukh]

David, just for the way Mozilla views messages it recieves

Comment 22

[Asa Dotzler [:asa]]

a= [e-mail] for checkin to the trunk.
(on behalf of drivers)

Comment 23

[Anatoliy Averbukh]

Checked in.

Comment 24

[[e-mail] (gone - use [e-mail] instead)]

I'm seeing yellow all over the place on : 

Mac OS 9.1 - 2001-06-25-08
Windows 2K - 2001-06-25-04
RedHat 7.1 - 2001-06-25-06