864476 - [FTE] the progression bar should be hidden in some panels

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[Julien Wajsberg [:julienw]]

STR:
* Run FTU until the "About B2G OS" panel
* open "About B2G OS", or "Your privacy", and any of the subpanels. Note that we need a network connection to display the subpanels. 

Expected:
* the progression bar is hidden

Actual:
* it is displayed (see screenshots)

I know for sure that this is a regression because I personally fixed this previously. Added qawanted to check if it's present in 1.1 and/or 1.0.1 (I saw this bug on master).

Comment 1

[Julien Wajsberg [:julienw]]

Attachment: screenshot 1

Comment 2

[Julien Wajsberg [:julienw]]

Attachment: screenshot 2

Comment 3

[Julien Wajsberg [:julienw]]

Attachment: screenshot 3

Comment 4

[Julien Wajsberg [:julienw]]

FTR I implemented this in Bug 812956, I'm bisecting right now.

Comment 5

[Julien Wajsberg [:julienw]]

The culprit is commit 4f1926a68a872f4cc48ae79314f2a48356325c2d, which is Bug 826623.

Comment 6

[Julien Wajsberg [:julienw]]

So this is probably in all branches.

Josh, I'd like your agreement that this should be removed.

Comment 7

[Julien Wajsberg [:julienw]]

Even asking tef? as this should be easy to do and I feel like this is the first thing the user will see.

Comment 8

[Julien Wajsberg [:julienw]]

Attachment: patch v1

Moved the className calculation before the switch-case so that we can override
it inside the switch-case.

Added a test case to prevent future regressions
---
 apps/communications/ftu/js/navigation.js           |   24 ++++---
 .../ftu/test/unit/mock_ui_manager.js               |   13 ++++
 .../ftu/test/unit/navigation_test.js               |   73 ++++++++++++++++++++
 apps/communications/test/unit/mocks_helper.js      |   58 ++++++++++++++++
 apps/communications/test/unit/setup.js             |    5 ++
 5 files changed, 164 insertions(+), 9 deletions(-)
 create mode 100644 apps/communications/ftu/test/unit/mock_ui_manager.js
 create mode 100644 apps/communications/ftu/test/unit/navigation_test.js
 create mode 100644 apps/communications/test/unit/mocks_helper.js
 create mode 100644 apps/communications/test/unit/setup.js

See also PR https://github.com/mozilla-b2g/gaia/pull/9348

Comment 9

[Angela Hubenya]

I was able to reproduce this on v1.0.1, as well as v1
The progress bar is displayed when the screens shown in attachments are viewed.

Unagi
Build ID: 20130422070206
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/3a67efe71e11
Gaia: b750757662209dad81942df13f9997d684e0d9b1

Build ID: 20130422070204
Kernel Date: Dec 5
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/dfa6bdc5e6da
Gaia: 3cdab45a783efadf9b97decf46bd15b83fb91ed8

Comment 10

[Fernando Campo (:fcampo)]

This is a dup of bug 845521, but as it has already a patch, I'm closing the other one instead.

Comment 12

[Julien Wajsberg [:julienw]]

Fernando you can steal the review if you feel like it ;)

Comment 13

[Fernando Campo (:fcampo)]

I was on it, actually :)

Comment 14

[Fernando Campo (:fcampo)]

Comment on attachment 740503 [details] [diff] [review]
patch v1

Patch looks cool, my only concern are the tests, which are gonna collide with the ones for bug 864699.

But as those ones are not tef+ and are gonna take a while till landed, I would go forward with this one, and I'll modify them later to fit in the style.

Thanks for the quick patch Julien

Comment 15

[Julien Wajsberg [:julienw]]

master: d172b22cd4992fef03d3a2facc64a9644b556e8a

Comment 16

[Julien Wajsberg [:julienw]]

Comment on attachment 740503 [details] [diff] [review]
patch v1

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Bug 826623.
User impact if declined: ugly bar is displayed over the pages displayed in the internal browser
Testing completed: yes + unit tests 
Risk to taking this patch (and alternatives if risky): low, no alternative
String or UUID changes made by this patch: none

Comment 17

[James Lal [:lightsofapollo]]

Uplifted d172b22cd4992fef03d3a2facc64a9644b556e8a to:
v1-train: 3b84b238ed2195a1bc71eaab428ee7b8f6ddbdeb

Comment 19

[buri.blff]

Pleas add this patch to v1.0.1 for bug:863538;

Comment 20

[buri.blff]

Dear jlal:
   can you add the patch to v1.0.1  for bug:863538?

Comment 21

[Julien Wajsberg [:julienw]]

buri> we need a tef+ before that. I asked tef? 2 weeks ago and it has not been given, either - or +, so you should first try to reach the drivers if you need this in 1.0.1.

Comment 22

[buri.blff]

Dear Julien:
I has add a tef? flage to 863538.

Comment 23

[Julien Wajsberg [:julienw]]

Daniel, could you please explain why this bug is not triaged to either tef- or tef+ ?

Comment 24

[Daniel Coloma:dcoloma]

We use tef-triage whiteboard to indicate those bugs I do not consider blockers but I would like Mozilla Release drivers to check just in case Mozilla disagrees. It seems this went out drivers queries. Lukas, wdyt?

Comment 25

[buri.blff]

This is a bug, there is path for this bug, the bug will affect user experience. why we can't add the patch to resolve this bug.

Comment 26

[Alex Keybl [:akeybl]]

We've held FTE to a higher standard, so we'll take this.

Comment 27

[Daniel Coloma:dcoloma]

John, can you please uplift this one? Thanks!

Comment 28

[John Ford [:jhford] CET/CEST Berlin Time]

There is a small merge conflict in apps/communications/ftu/js/navigation.js

++<<<<<<< HEAD
 +        UIManager.progressBar.className = 'step-state step-7';
 +        UIManager.mainTitle.innerHTML = _('browserPrivacyChoices');
++=======
+         UIManager.mainTitle.innerHTML = _('aboutBrowser');
++>>>>>>> 3b84b23... Bug 864476 - [FTE] the progression bar should be hidden in some panels r=arcturus

Comment 29

[Julien Wajsberg [:julienw]]

v1.0.1: 3178923bf62d500240c9f11c1157fae895e79ec6

Comment 30

[Deepa Subramanian]

This issue does not repro any more. The progress bar is not shown as per the attachments. The user is also able to see a banner to connect to the internet. 

Verified on 

Inari Build ID: 2013053170208
Gecko:Gecko  http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/be5c2ee11d02
Gaia:  e7114bdf4078274fc127a3b2a58dad91d6884219

LEO Build ID: 20130531070205
Gecko: Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/4f318822e72c
Gaia   e1c59baed29e4665d1da9392f86239272073f07a