864490 - [B2G][Leo][Camera] Toolbar at the bottom does not hide after tapping on a new photo

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::Camera, enhancement, P2)

Description

[Deepa Subramanian]

Description:
The user sees the tool bar after tapping on a newly taken photo.  

Repro Steps:
1) Updated to Leo Build ID: 20130411070205
2) Go to Camera app picture using the camera app
3) Tap on the camera icon
4) Take a photo
5) Tap on photo taken (top left)
6) See the toolbar present

Actual:
User sees the photo along with the toolbar

Expected:
Toolbar is hidden after tapping the new photo 

Environmental  Variables: 
Kernel Date: Mar 15
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/f671fa539473
Gaia: e7e338a765e22334b40ced41489a785941382c66

Notes:
Repro frequency: 100%
Test Suite Name: Camera
UCID: Camera-003
Link to failed test case: https://moztrap.mozilla.org/runtests/run/1117/env/314/?pagenumber=1&pagesize=20&sortfield=order&sortdirection=asc&filter-id=3467
Screenshot: attached for more info.

Comment 1

[Deepa Subramanian]

Attachment: Bug 864490 - toolbar found on the new photo taken

Comment 2

[Mike Habicher [:mikeh] (high bugzilla latency)]

This looks like the Gallery app, and the UI looks okay to me.  Checking with djf.

Comment 3

[David Flanagan [:djf]]

I don't think this is a bug. The screenshot shows a photo being previewed within the Camera app. I don't think we actually have a good UX spec for this screen. But given that we've got a filmstrip on top that is permanent, I think the toolbar on the bottom should be permanent too.  If the user wants to see the photo fullscreen, they can go to the gallery app.

I think that the use case on which this testcase is based is invalid.  I think we should get UX to review before altering the camera app to match this use case.  If we hide that toolbar, I think the user might get confused about how to get back to the camera.  And, as noted above, it doesn't make sense to hide the toolbar without also hiding the filmstrip.

Basically, the camera app was never designed to meet this use case.

Casey, would you either declare the use case and its test invalid or specify how the app should behave here?

Comment 4

[Casey Yee]

I would certainly agree that it would be an improvement to offer a control-less full-screen view in the same way that it works while viewing images in gallery app.   

We will track this bug as a UX improvement when we re-design the camera app.

Comment 5

[John Hammink]

I'm assuming that we can still track this.  Removing whiteboard.

Comment 6

[John Hammink]

Nominating for Koi?  as a suggestion for future version.

Comment 7

[Jeni]

Issue repros on 
Leo Build ID: 20130610070206
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/8e3f39363c54
Gaia: ce3b99781d182ad550a325206990c249b0dbcf0e
Platform Version: 18.0

When user takes a picture and views picture from camera application the tool bar is not hidden when user taps on the screen.

Comment 8

[John Hu [:johnhu][:johu][:醬糊小弟]]

start to watch it and think a possible implementation for it.

Comment 9

[John Hu [:johnhu][:johu][:醬糊小弟]]

Unassign myself. I may take it if the UX is ready.

Comment 10

[Wilson Page [:wilsonpage]]

The toolbar in question doesn't exist in new camera.