864515 - [Dialer] Invalid message shown when coverage is absent

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect, P2)

Description

[John Hammink]

Build info:
Gaia   080ef2e2041178f7e4d669c7ee5c30f6a7263896
BuildID 20130328103121
Version 18.0

Preconditions:
Carry the phone to any place where the Movistar's signal is not present. There, the phone must allow only emergency calls.

Steps to Reproduce:
Enter a valid mobile number and press the send key.    

Actual Result:
The phone informs the user that the dialed number is invalid; but the real reason that that call cannot go through is that there is no coverage.  The message is: 

"Número de teléfono no válido
El número de teléfono al que está llamando no es válido."

Expected Result:
The correct message should inform the user about absence of <carrier's> coverage.  

In the case of certification, this means Movistar.

Comment 1

[John Hammink]

Attachment: Screenshot of the incorrect message.

Comment 2

[David Palomino [:dpalomino]]

Hi, 

This is not a certification blocker, I'd suggest to move this issue to tef-. 

Thanks
David

Comment 3

[Lukas Blakk [:lsblakk] use ?needinfo]

Sounds like we should track this for getting a better user experience, but not block.

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Etienne do you know if this is because RIL gives us a wrong error message or is it because we handle a error message in a too generic way in the dialer app?

Comment 5

[Etienne Segonzac (:etienne)]

Looks like we expect a BadNumber error a try to do the right thing [1].

But for this to work we may need to refine our detection of when only emergency calls are available [2].

Can somebody log the |window.navigator.mozMobileConnection.cardState| we have during the STR?


[1] https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/dialer/js/telephony_helper.js#L54-58
[2] https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/dialer/js/telephony_helper.js#L25-28

Comment 6

[Julien Wajsberg [:julienw]]

I think emergencyCalls is detected with :

"window.navigator.mozMobileConnection.voice.emergencyCallsOnly === true"

see eg https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/statusbar.js#L541

Comment 7

[Etienne Segonzac (:etienne)]

(In reply to Julien Wajsberg [:julienw] (PTO until Monday 13th May) from comment #6)
> I think emergencyCalls is detected with :
> 
> "window.navigator.mozMobileConnection.voice.emergencyCallsOnly === true"

Cool! Thanks Julien!

Should be pretty straightforward then, we need to change the telephony helper to use this property in order to detect if we're in a emergency calls only mode.

Comment 8

[John Hammink]

FWIW, problem does not appear on B02 build (4/26) in Chile certification, nor on 5/13 build.

Comment 9

[Juan Perez-Bedmar [:juanpbf]]

Hi 

I have just tried with the official version delivered to certif. lab for the final IOT round, and I still see this issue.

QC RIL version:
"ro.build.firmware_revision=V1.01.00.01.019.120"
gaia commit:
50abeb2 Merge pull request #10032 from alivedise/bugzilla/872912_v1.0.1b
gecko commit:
a6a5487 Bug 875483 - YouTube HTML5 Playback hangs Firefox. r=derf,a=tef+

For sure this not a blocking issue, but I suggest to fix it for leo, as it improves the UX.

nominating it to leo?

Comment 10

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: Link to https://github.com/mozilla-b2g/gaia/pull/10206

Etienne, the change is based on comment 6. Please help review it, thanks!

Comment 11

[Etienne Segonzac (:etienne)]

Comment on attachment 758431 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/10206

Commented on github, should be a quick fix :)

Comment 12

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 758431 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/10206

Thanks for reviewing! Please check my reply in github.

Comment 13

[Etienne Segonzac (:etienne)]

Comment on attachment 758431 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/10206

r=me (17f026ac9f75bdfae81d379d021a9e9a85bae09b)

Thanks!

Comment 14

[Arthur Chen [:arthurcc][inactive after 6/30]]

master: https://github.com/mozilla-b2g/gaia/commit/a1f8ab56c638bbbbb9d3b47c56f2c6a344dfdb42

Comment 15

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted a1f8ab56c638bbbbb9d3b47c56f2c6a344dfdb42 to:
v1-train: f1b765fd98ae40865862e0b89fc66f77be5a6e02