makeapi search field for email

RESOLVED FIXED

Status

Webmaker
MakeAPI
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: thecount, Assigned: thecount)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
When bug 863403 landed, it added a seprate field for email.

This is great, but it looks like it is lacking a field to search by email.

I was previously using author for this, email is much better.

I've got a patch for this I can make into a pull request.
(Assignee)

Updated

5 years ago
Assignee: nobody → scott
(Assignee)

Comment 1

5 years ago
Created attachment 740523 [details]
https://github.com/mozilla/MakeAPI/pull/27

Let me know if I am on the right track/missed anything.
Attachment #740523 - Flags: review?(schranz.m)
(Assignee)

Updated

5 years ago
Blocks: 861816
Comment on attachment 740523 [details]
https://github.com/mozilla/MakeAPI/pull/27

One nit.
Attachment #740523 - Flags: review?(schranz.m) → review-
(Assignee)

Comment 3

5 years ago
Comment on attachment 740523 [details]
https://github.com/mozilla/MakeAPI/pull/27

Updated.

Curious, what's the difference?

Does query expose the content as searchable via elastic search?
Attachment #740523 - Flags: review- → review?(schranz.m)
Comment on attachment 740523 [details]
https://github.com/mozilla/MakeAPI/pull/27

R+

Like said in person, using Term filter vs Query Filter w/ Field Query seems to prevent any potential issues with what elastic search calls "Analyzers" which can cause us to get unintended results.
Attachment #740523 - Flags: review?(schranz.m) → review+
(Assignee)

Comment 5

5 years ago
Staged: https://github.com/mozilla/MakeAPI/commit/ba53477d80a7ccc06f9ea303c857092b5ee4a629
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.