Closed Bug 864544 Opened 9 years ago Closed 9 years ago

make HTMLMediaElement::mPlayed an nsRefPtr

Categories

(Core :: Audio/Video, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: rillian, Assigned: rillian)

Details

Attachments

(1 file)

From an IRC discussion. Smaug suggested in HTMLMediaElement we:

  nsRefPtr<TimeRanges> mPlayed;

and

  NS_IMPL_CYCLE_COLLECTOR_TRAVERSAL(mPlayed);
You also need an UNLINK in the unlink part.
Yeah, usually you want also UNLINK when you TRAVERSE
Attached patch patchSplinter Review
Attachment #740550 - Attachment is patch: true
Attachment #740550 - Attachment mime type: application/mbox → text/plain
Comment on attachment 740550 [details] [diff] [review]
patch

Review of attachment 740550 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

Olli: are the UNLINK/TRAVERSE macros correct?
Attachment #740550 - Flags: review?(cpearce)
Attachment #740550 - Flags: review?(bugs)
Attachment #740550 - Flags: review+
Attachment #740550 - Flags: review?(bugs) → review+
Try is green except for a webgl xpass.

https://hg.mozilla.org/integration/mozilla-inbound/rev/59691d48243e
https://hg.mozilla.org/mozilla-central/rev/59691d48243e
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.