864553 - Remove MOZ_FLEXBOX ifdefs

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Daniel Holbert [:dholbert]]

Flexbox has been compiled by default for months, and is pref-controlled, so we can toggle it on/off with the pref if we need to.

Filing this bug on removing all of the #ifdef MOZ_FLEXBOX cruft.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: part 1: remove #ifdefs and configure.in chunk

This patch is purely #ifdef / #endif removal for MOZ_FLEXBOX, along with the corresponding chunk of configure.in.

I'll post a second patch to do a bit of code-cleanup for a few spots that are left a bit awkward without the #ifdef/#endif

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: part 2: minor code-cleanup now that #ifdefs are gone

This patch takes care of a few minor cleanup things that I left out of the previous patch to make it essentially all #ifdef-removal:

 a) moves a now-straggling-among-other-#ifdefs nsFlexContainerFrame-include up to a non-#ifdeffy region.

 b) merges the formerly ifdef-MOZ_FLEXBOX-wrapped chunks of two Makefile.in files in with the rest of their file.

 c) cleans up the style around a "&& flexContainerFrame" line that awkwardly starts with "&&" because it used to be #ifdef-wrapped.

Not sure if it's clearer as 2 separate patches like this, or as a single merged patch. I'll post the rollup patch, too, in case you'd prefer to review that.

Comment 3

[Daniel Holbert [:dholbert]]

Attachment: rollup patch

Comment 4

[David Baron :dbaron:]

Comment on attachment 740675 [details] [diff] [review]
part 1: remove #ifdefs and configure.in chunk

r=dbaron

Comment 5

[David Baron :dbaron:]

Comment on attachment 740680 [details] [diff] [review]
part 2: minor code-cleanup now that #ifdefs are gone

r=dbaron

Comment 6

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ae6f8ea61f33
https://hg.mozilla.org/integration/mozilla-inbound/rev/c78f21f990fd

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/ae6f8ea61f33
https://hg.mozilla.org/mozilla-central/rev/c78f21f990fd