Remove MOZ_FLEXBOX ifdefs

RESOLVED FIXED in mozilla24

Status

()

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

Trunk
mozilla24
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Assignee)

Description

5 years ago
Flexbox has been compiled by default for months, and is pref-controlled, so we can toggle it on/off with the pref if we need to.

Filing this bug on removing all of the #ifdef MOZ_FLEXBOX cruft.
(Assignee)

Updated

5 years ago
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
(Assignee)

Comment 1

5 years ago
Created attachment 740675 [details] [diff] [review]
part 1: remove #ifdefs and configure.in chunk

This patch is purely #ifdef / #endif removal for MOZ_FLEXBOX, along with the corresponding chunk of configure.in.

I'll post a second patch to do a bit of code-cleanup for a few spots that are left a bit awkward without the #ifdef/#endif
Attachment #740675 - Flags: review?(dbaron)
(Assignee)

Comment 2

5 years ago
Created attachment 740680 [details] [diff] [review]
part 2: minor code-cleanup now that #ifdefs are gone

This patch takes care of a few minor cleanup things that I left out of the previous patch to make it essentially all #ifdef-removal:

 a) moves a now-straggling-among-other-#ifdefs nsFlexContainerFrame-include up to a non-#ifdeffy region.

 b) merges the formerly ifdef-MOZ_FLEXBOX-wrapped chunks of two Makefile.in files in with the rest of their file.

 c) cleans up the style around a "&& flexContainerFrame" line that awkwardly starts with "&&" because it used to be #ifdef-wrapped.

Not sure if it's clearer as 2 separate patches like this, or as a single merged patch. I'll post the rollup patch, too, in case you'd prefer to review that.
Attachment #740680 - Flags: review?(dbaron)
(Assignee)

Comment 3

5 years ago
Created attachment 740681 [details] [diff] [review]
rollup patch
Comment on attachment 740675 [details] [diff] [review]
part 1: remove #ifdefs and configure.in chunk

r=dbaron
Attachment #740675 - Flags: review?(dbaron) → review+
Comment on attachment 740680 [details] [diff] [review]
part 2: minor code-cleanup now that #ifdefs are gone

r=dbaron
Attachment #740680 - Flags: review?(dbaron) → review+
https://hg.mozilla.org/mozilla-central/rev/ae6f8ea61f33
https://hg.mozilla.org/mozilla-central/rev/c78f21f990fd
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla24
You need to log in before you can comment on or make changes to this bug.