Closed Bug 864578 Opened 9 years ago Closed 9 years ago

Parser complains about NamedConstructor and NoInterfaceObject being incompatible, spec allows it

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: reuben, Assigned: reuben)

Details

Attachments

(1 file, 1 obsolete file)

[NoInterfaceObject,
 NamedConstructor=mozFoo]
interface Foo { }

WebIDL.WebIDLError: error: NamedConstructor and NoInterfaceObject are incompatible
Attached patch Fix (obsolete) — Splinter Review
Assignee: nobody → reuben.bmo
Attachment #740572 - Flags: review?(bzbarsky)
Sorry about that.
Attachment #740572 - Attachment is obsolete: true
Attachment #740572 - Flags: review?(bzbarsky)
Attachment #740573 - Flags: review?(bzbarsky)
Comment on attachment 740573 [details] [diff] [review]
Patch, minus whitespace hell

For that last test, you don't need the try/catch or threw variable.  Just run the code, and if it throws the test will fail.

But you _do_ need to do |parser = parser.reset()|.

r=me with that and with the missing newline at EOF added.
Attachment #740573 - Flags: review?(bzbarsky) → review+
Er, you need the reset() _before_ your test, to reset it from the previous test....
Nah, I'm just sorry I didn't make that clearer.  :(
https://hg.mozilla.org/mozilla-central/rev/138187d07a1c
https://hg.mozilla.org/mozilla-central/rev/f1f6be722f2a
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.