864578 - Parser complains about NamedConstructor and NoInterfaceObject being incompatible, spec allows it

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Reuben Morais [:reuben]]

[NoInterfaceObject,
 NamedConstructor=mozFoo]
interface Foo { }

WebIDL.WebIDLError: error: NamedConstructor and NoInterfaceObject are incompatible

Comment 1

[Reuben Morais [:reuben]]

Attachment: Fix

Comment 2

[Reuben Morais [:reuben]]

Attachment: Patch, minus whitespace hell

Sorry about that.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 740573 [details] [diff] [review]
Patch, minus whitespace hell

For that last test, you don't need the try/catch or threw variable.  Just run the code, and if it throws the test will fail.

But you _do_ need to do |parser = parser.reset()|.

r=me with that and with the missing newline at EOF added.

Comment 4

[Reuben Morais [:reuben]]

Thanks!

https://hg.mozilla.org/integration/mozilla-inbound/rev/138187d07a1c

Comment 5

[Boris Zbarsky [:bzbarsky]]

Er, you need the reset() _before_ your test, to reset it from the previous test....

Comment 6

[Reuben Morais [:reuben]]

Follow up of shame: https://hg.mozilla.org/integration/mozilla-inbound/rev/f1f6be722f2a

:(

Comment 7

[Boris Zbarsky [:bzbarsky]]

Nah, I'm just sorry I didn't make that clearer.  :(

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/138187d07a1c
https://hg.mozilla.org/mozilla-central/rev/f1f6be722f2a