864603 - Netmonitor tests produce incorrect messages

Status: RESOLVED INVALID

(DevTools :: Netmonitor, defect)

Description

[Norbert Lindenberg]

The output of the Netmonitor tests in log files is full of statements that something is incorrect, e.g.
| The attached method is incorrect.
| The attached url is incorrect.
| The displayed method is incorrect.
| The displayed file is incorrect.
| The tooltip file is incorrect.
| The displayed domain is incorrect.
etc. in the browser_net_json-long.js portion of
https://tbpl.mozilla.org/php/getParsedLog.php?id=22111230&tree=Try&full=1

I suspect these messages were meant to be output only in case of actual failures, but they show up in otherwise successful test runs.

Comment 1

[Victor Porof [:vporof][:vp]]

(In reply to Norbert Lindenberg from comment #0)
> 
> I suspect these messages were meant to be output only in case of actual
> failures, but they show up in otherwise successful test runs.

Verification functions ("ok", "is" etc.) print out the message regardless of their result. So even if a check is successful, the message is displayed anyway. I guess it would be nicer if the message read "The attached method is correct" instead of "incorrect", but that's just esthetics.