Closed
Bug 86462
Opened 23 years ago
Closed 20 years ago
Remove 'text-align:-moz-initial;' from UA CSS
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
Future
People
(Reporter: fantasai.bugs, Assigned: annevk)
Details
(Keywords: css-moz, css3, helpwanted)
Attachments
(1 file)
|
764 bytes,
patch
|
dbaron
:
review+
dbaron
:
superreview+
|
Details | Diff | Splinter Review |
We currently have both "text-align: start" and "text-align: -moz-initial" in the UA stylesheets. Both are implemented, but we should use either one or the other, not both. text-align: start pros - it's in the *CSS3 Text Module* Working Draft cons - it's in the CSS3 Text Module *Working Draft* text-align: -moz-initial pros - it will never be official CSS cons - it's not official CSS Hyatt, I'm assigning to you because you put them both in your patch for bug 78695.
|
||
Comment 1•23 years ago
|
||
Actually, glazman proposed "initial" to the CSS WG, and my understanding is that they thought is was ok.
Status: NEW → ASSIGNED
|
||
Updated•23 years ago
|
|
|
||
Updated•23 years ago
|
Target Milestone: --- → Future
|
Assignee | |
Comment 2•21 years ago
|
||
WONTFIX?
|
||
Comment 3•21 years ago
|
||
No, we should indeed use one or the other, for cleanliness if nothing else. I think we should use 'start'.
|
|
Assignee | |
Comment 4•21 years ago
|
||
Since the CSS3 Text Module is now a CR Mozilla is encouraged to follow it (<http://www.w3.org/TR/css3-text/#alignment-prop>). If '-moz-initial' is still there, it should be removed.
QA Contact: chrispetersen → ian
Summary: "text-align: start" OR "text-align: -moz-initial" in UA CSS → Remove 'text-align:-moz-initial;' from UA CSS
Assignee: hyatt → dbaron
Status: ASSIGNED → NEW
Component: Layout → Style System (CSS)
|
||
Comment 5•20 years ago
|
||
We're talking about <http://lxr.mozilla.org/seamonkey/source/layout/html/document/src/quirk.css#111>, right? Patches are welcome!
Keywords: helpwanted
|
|
Assignee | |
Comment 6•20 years ago
|
||
Thanks Michiel for creating the diff. Without his help I would never be able to change this one line in quirk.css :-D
|
|
Assignee | |
Updated•20 years ago
|
Attachment #148185 -
Flags: review?(bzbarsky)
Attachment #148185 -
Flags: approval1.7?
|
|
Assignee | |
Updated•20 years ago
|
Attachment #148185 -
Flags: superreview?(bzbarsky)
|
|
Assignee | |
Comment 7•20 years ago
|
||
Comment on attachment 148185 [details] [diff] [review] patch Removing bz, I heard he is busy enough.
Attachment #148185 -
Flags: superreview?(dbaron)
Attachment #148185 -
Flags: superreview?(bzbarsky)
Attachment #148185 -
Flags: review?(dbaron)
Attachment #148185 -
Flags: review?(bzbarsky)
Comment on attachment 148185 [details] [diff] [review] patch Anne, don't flag trivial bugs like this for a release that's already branched. Unless it's a crash fix or dataloss fix, the trunk is fine.
Attachment #148185 -
Flags: approval1.7?
Attachment #148185 -
Flags: superreview?(dbaron)
Attachment #148185 -
Flags: superreview+
Attachment #148185 -
Flags: review?(dbaron)
Attachment #148185 -
Flags: review+
|
|
||
Updated•20 years ago
|
Assignee: dbaron → bug
|
|
Assignee | |
Comment 9•20 years ago
|
||
Marking my very first, albeit a very simple 1 line change, bug FIXED. Many thanks to Boris and Michiel.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 10•20 years ago
|
||
Argh, I forgot the reviewer himself, David, thanks!
You need to log in
before you can comment on or make changes to this bug.
Description
•