864620 - [FTU] Pressing power button does nothing during FTO.

Status: RESOLVED DUPLICATE of bug 814840

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Leo]

1. Title : [FTU] Pressing power button does nothing during FTO.
2. Precondition : Have FTU running.
3. Tester's Action : Press power button.
4. Detailed Symptom (ENG.) : Pressing power button does nothing.
5. Expected : Screen is expected to turn off when power button is pressed.
6. Reproducibility: Y
   1)Frequency Rate : 100%

This is caused by the following code in turnScreenOff function of screen_manager.js

    if (instant) {
      if (!WindowManager.isFtuRunning()) {
        screenOff();
      }
      return true;
    }


I have checked the screen_manager.js in both master and v1-train git.

In master, it is as follows.
https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/screen_manager.js

    if (instant) {
      screenOff();
      return true;
    }

In v1-train, it is as follows.
https://github.com/mozilla-b2g/gaia/blob/v1-train/apps/system/js/screen_manager.js

    if (instant) {
      if (!WindowManager.isFtuRunning()) {
        screenOff();
      }
      return true;
    }


Should we make the same in v1-train as in master?

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

I believe you are looking at the change made by bug 814840. You should be able to |git annotate| the code and find that.

Let's either 1) mark this bug as dup of that, and request uplift on that bug, or 2) provide a minimum v1-only fix on this bug. I personally prefer (1).

Comment 2

[Leo]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) from comment #1)
> I believe you are looking at the change made by bug 814840. You should be
> able to |git annotate| the code and find that.
> 
> Let's either 1) mark this bug as dup of that, and request uplift on that
> bug, or 2) provide a minimum v1-only fix on this bug. I personally prefer
> (1).

Let's do (1). Thanks!