864648 - make VideoConduits share a single VideoEngine similar to AudioConduits

Status: RESOLVED DUPLICATE of bug 864654

(Core :: WebRTC: Audio/Video, defect, P2)

Description

[Randell Jesup [:jesup] (needinfo me)]

Attachment: merge backend for send and receive VideoConduits to match AudioConduits

Make VideoConduits and AudioConduits similar (by sharing a single VideoEngine/channel).  This will allow a bidirectional pair of conduits to avoid trying to send RTCP from the "wrong" conduit/transport, among other improvements.

Note that both video and audio conduits should be refactored to create a single class for each that wraps the Engine/etc and that the pair of conduits use.

Helps resolve issues in bug 859971 by making the bidirectional case work with no dropped RTCP (send-only streams still have a problem in that the receiver can't receive RTCP on a "receive-only" conduit.)

Comment 1

[Suhas]

" Note that both video and audio conduits should be refactored to create a single class for each that wraps the Engine/etc and that the pair of conduits use."

    - Randell, if i understand this correctly, the need here is to create engine wrapper classes  and expose that wrapper to tx/rx conduits, so as to move all the gips related code into the wrapper class(s)

please confirm

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 740664 [details] [diff] [review]
merge backend for send and receive VideoConduits to match AudioConduits

This patch has been obsoleted by the bidirectional-refactor patch from bug 864654; this bug itself may now be moot or a dup of that bug.