Closed Bug 864775 Opened 9 years ago Closed 9 years ago

Use proper compartment when deserializing ArrayBuffer from parent process

Categories

(Core :: DOM: Core & HTML, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla23
blocking-b2g tef+
Tracking Status
b2g18 --- fixed
b2g18-v1.0.1 --- fixed

People

(Reporter: jdm, Assigned: jdm)

References

Details

(Whiteboard: [fixed-in-birch])

Attachments

(1 file, 2 obsolete files)

Without this, the email app remains broken.
Assignee: nobody → josh
Thanks, I can confirm the patch fixes email on my Nexus S too.
Comment on attachment 740818 [details] [diff] [review]
Use unwrapped content window object to determine compartment when creating new ArrayBuffers for use by content from TCPSocket. r=

For reference, useWin comes from unwrapping (http://hg.mozilla.org/mozilla-central/annotate/acf388eaf9e9/dom/network/src/TCPSocket.js#l306) the window provided as part of nsIDOMGlobalPropertyInitializer.init.
Attachment #740818 - Flags: review?(bzbarsky)
Yeah, confirmed on unagi for v1-train too.  Thanks, Josh!
Comment on attachment 740818 [details] [diff] [review]
Use unwrapped content window object to determine compartment when creating new ArrayBuffers for use by content from TCPSocket. r=

r=me
Attachment #740818 - Flags: review?(bzbarsky) → review+
Attachment #740818 - Attachment is obsolete: true
Attachment #740870 - Attachment is obsolete: true
And https://hg.mozilla.org/projects/birch/rev/761a78c8ab03 because, yeah, running tests is good.
Needed for bug 863770 which is tef+ so tef+ here, too.
blocking-b2g: tef? → tef+
I uplifted patched 1, 3, and 4 to mozilla-b2g18 which are equivalent to the updated b2g18 patch here on the bug after running tests.  (Patch 2 was a fix for m-c for a patch made for 18.)  This was done for maximum correspondence, but done as a push so push-aware bisection should be happy.

https://hg.mozilla.org/releases/mozilla-b2g18/rev/6809f965cdd7
https://hg.mozilla.org/releases/mozilla-b2g18/rev/d51b1bb27054
https://hg.mozilla.org/releases/mozilla-b2g18/rev/2376197bf4de

I'll uplift to v1.0.1 once it's clear that a git mirror derived build is 100% happy with this and TBPL remains equivalently happy.
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.