864867 - [Email] When mail body is larger than 4k, the fetch of the remainder of the body forgets the already-retrieved first 4k.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[:gerard-majax]

Attachment: Missing part on Avaaz mail

On gaia master from today, d092d01, I'm getting issues with HTML rendering on some mails: parts of the mail disappears.

Comment 1

[:gerard-majax]

Attachment: Content of the Avaaz mail triggering the issue.

Comment 2

[:gerard-majax]

Attachment: Europcar mail part 1

Comment 3

[:gerard-majax]

Attachment: Europcar mail part 2

Comment 4

[:gerard-majax]

Attachment: Europcar HTML source

Comment 5

[:gerard-majax]

Attachment: ADVCOMP mail source

It seems it is not limited to HTML mails ... See this one. (screenshot next)

Comment 6

[:gerard-majax]

Attachment: ADVCOMP mail rendering

Remember this one is text only ...

Comment 7

[:gerard-majax]

Could there be some link with bug 864775 and bug 831107 ?

Comment 8

[:gerard-majax]

As being asked on IRC, this does not seems to be related to my IMAP server; I'm reproducing it also from a Gmail account with the same email. Please note that the cutting occurs roughly at the same place (delta is around 10 characters).

Comment 9

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Are you using v1.0.1 or v1.1 code?  I noticed something funny in regards to line breaks for Japanese as well : bug 862607

Can you try with code from master?

Comment 10

[:gerard-majax]

(In reply to Naoki Hirata :nhirata (please use needinfo instead of cc) from comment #9)
> Are you using v1.0.1 or v1.1 code?  I noticed something funny in regards to
> line breaks for Japanese as well : bug 862607
> 
> Can you try with code from master?

As stated in comment #1, I'm using master from yesterday, commit d092d01.

Comment 11

[Joe Cheng [:jcheng] (please needinfo)]

traige: leo+, bad html rendering problem making it difficult to read emails

Comment 12

[:gerard-majax]

(In reply to Joe Cheng [:jcheng] from comment #11)
> traige: leo+, bad html rendering problem making it difficult to read emails

Please, this is not limited to HTML rendering, it also hits plain text.

Comment 14

[Andrew Sutherland [:asuth] (he/him)]

To clarify, this indeed will affect all types of e-mails.  It's just that it's much more likely that HTML emails will exceed 4k in size.

Comment 15

[James Lal [:lightsofapollo]]

Yeah this is my fault... I will pick this up after my other tef+ bug (next 1-3 days). Not assigning myself yet.

Comment 16

[James Lal [:lightsofapollo]]

Attachment: Correctly merge partial downloads.

Comment 17

[James Lal [:lightsofapollo]]

OK I lied... simple fix.

Comment 18

[Andrew Sutherland [:asuth] (he/him)]

landed on gaia-email-libs-and-more/master:
https://github.com/mozilla-b2g/gaia-email-libs-and-more/pull/191
https://github.com/mozilla-b2g/gaia-email-libs-and-more/commit/a57ea5b43b02a9f6bc814296fe4fbede4d692c75

landed on gaia/master:
https://github.com/mozilla-b2g/gaia/pull/9471
https://github.com/mozilla-b2g/gaia/commit/5944dfb3fb724755fde23d6cccb0f1bfa218e065

Comment 19

[Andrew Sutherland [:asuth] (he/him)]

This *really* wants a tef+ uplift.  Display of e-mails larger than 4k is fundamentally broken without this fix.  If you don't want it on tef, please give us back our leo+.

Comment 20

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 5944dfb3fb724755fde23d6cccb0f1bfa218e065 to:
v1-train: 3cb40c1c44d26d0705a3c317861174c21f3e4b2c
v1.0.1: 59d8c2e750490679765b447e43bb77a80a3f9f39

Comment 21

[Cody Roesch [:croesch]]

Can you please provide steps to verify this fix - as we will blackbox test from the UI?

Comment 22

[Andrew Sutherland [:asuth] (he/him)]

(In reply to croesch from comment #21)
> Can you please provide steps to verify this fix - as we will blackbox test
> from the UI?

The test I described on https://bugzilla.mozilla.org/show_bug.cgi?id=857900#c8 is the same thing you would want to test here; this bug fixes a bad regression from that bug.  Since that was QARegressExclude, I'll mark that on this too.