864922 - Feature: Add field for Partner Engineer to be cc'ed on review

Status: RESOLVED FIXED

(Marketplace Graveyard :: Reviewer Tools, defect)

Description

[:Harald Kirschner :digitarald]

Marketplace currently allows a BD contact to be cc'ed on review result. Please add a field for Partner Engineering contact.

If a partner engineer is already in contact with the partners engineering team, it would make responses and hands-on help much faster when he gets notified with review feedback and can add additional notes.

This keeps up the energy on the partner side, keeps partner engineers in the loop and reduces forwarded emails. It also adds a new feedback-loop between partner engineering and the review team to improve and extend the provided feedback.

The combination of BD shouting encouragement and a partner engineer giving additional technical notes should tighten the review-resubmission loop.

It's a simple change and can be used versatility. A simple first step would be to allow a list of people for BD contact.

I'd love to hear thoughts! Do you see any drawbacks?

Comment 1

[:Harald Kirschner :digitarald]

Thinking about it, having one field for CCs that holds many user references would be better than adding fields for specific roles; if that's possible.

E.g. Evangelism might also want to be cc'ed for partners that they are coaching.

Comment 2

[Andrew Williamson [:eviljeff]]

Just make the current contact field support a comma separated list.  (It has the bonus of requiring zero UX work.)

Comment 3

[:Harald Kirschner :digitarald]

(In reply to Andrew Williamson [:eviljeff] from comment #2)
> Just make the current contact field support a comma separated list.  (It has
> the bonus of requiring zero UX work.)

Agreed, that seems to be the simplest solution, low-impact and low-risk.

Comment 4

[Thomas Elin [:relaas]]

(In reply to Harald Kirschner :digitarald from comment #3)
> (In reply to Andrew Williamson [:eviljeff] from comment #2)
> > Just make the current contact field support a comma separated list.  (It has
> > the bonus of requiring zero UX work.)
> 
> Agreed, that seems to be the simplest solution, low-impact and low-risk.

Also agree. Can we move forward on this asap? I'm planning to use this to help Partner Engineering track and proactively respond to the preload app bugs that are being reported by OEM's and Carriers.

Comment 5

[Maria Sandberg [:mushi]]

This seems like an easy and good change to me. Adding Bram who owns the design for this to get his input. Do we currently have a label for the cc field? If so, would we need to change that?

Comment 6

[Andrew Williamson [:eviljeff]]

The label is 'Mozilla Contact'; the tooltip beside it is 'An e-mail address of this app's Mozilla Contact that will be CC'd on any reviewer emails'.  

Change to 'Mozilla Contact(s)' and 'A comma-separated list of e-mail addresses of this app's Mozilla Contact(s) that will be CC'd on any reviewer emails'.

Comment 7

[Bram Pitoyo [:bram]]

I agree with Andrew’s suggestion on comment 2 and comment 6. Textbox that supports comma-separated lists is the easiest solution.

Can I get the screenshot or the URL of this text box, though, for a sanity check?

Comment 8

[Andrew Williamson [:eviljeff]]

Attachment: screenshot of Admin Setting section, showing Mozilla contact field

Comment 9

[Bram Pitoyo [:bram]]

(In reply to Andrew Williamson [:eviljeff] from comment #8)
> Created attachment 741575 [details]
> screenshot of Admin Setting section, showing Mozilla contact field

The tooltip you proposed on Comment 6 sounds fine. Additionally, let’s add a caption text (similar to the “264px x 184px” caption) below the “Mozilla Contact” heading that says:

Long version:
“You can enter more than one email address by separating each address with a comma”

Short version (if the long version breaks the layout too much):
“Enter email addresses, separated by commas”

Comment 10

[Thomas Elin [:relaas]]

When can we expect this to be implemented? As mentioned above this will be extremely useful in tracking/supporting Partner Engineering efforts. We have a hard deadline coming up 5/10 for content so the sooner the better :)

Comment 11

[Wil Clouser [:clouserw]]

We'll have a triage meeting next week and try to get it into this quarter.

Comment 12

[Rob Hudson [:robhudson]]

https://github.com/mozilla/zamboni/commit/22f10b8