Closed Bug 864925 Opened 11 years ago Closed 8 years ago

Consolidate places related needed by interests to PlacesInterestsUtils.jsm module

Categories

(Toolkit :: Places, defect)

Product:
Toolkit
Component:
Places
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED INCOMPLETE

People

(Reporter: Mardak, Unassigned)

References

Details

(Whiteboard: p=0)

Attachments

(1 file, 3 obsolete files)

v1 code and tests
9.96 KB, patch
Details | Diff | Splinter Review
Attached patch v1 (obsolete) — — Splinter Review 
There's currently 10 queries that the interests service makes use of:

addInterestHost: Record the pair of interest and host

addInterestVisit: Increment or initialize the number of visits for an interest on a day

clearRecentVisits:Clear recent visits for all interests

getBucketsForInterests: Generate buckets data for interests

getDiversityForInterests: Compute diversity values for interests

getInterests: Obtains interest metadata for a list of interests

getRecentHistory: Fetch recent history visits to process by page and day of visit

getScoresForInterests: Get a sorted array of interests by score

getScoresForNamespace: Get a sorted array of top interests for a namespace by score

setInterest: Set (insert or update) metadata for an interest

Note the patch doesn't build because I didn't include the xpcshell.ini but I did include the tests for reference. (The build system complains when there's test files without the matching xpcshell.ini updates.)
Attachment #740957 - Flags: review?(mak77)
Attached patch v1 code changes (obsolete) — — Splinter Review 

        Attachment #740957 -
        Attachment is obsolete: true

        Attachment #740957 -
        Flags: review?(mak77)

        Attachment #740960 -
        Flags: review?(mak77)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        v1 tests (obsolete)
        — 
          — Splinter Review
      

    


  

    
    

    
  
Comment on attachment 740960 [details] [diff] [review]
v1 code changes

clearing per decision to split the component apart in toolkit

        Attachment #740960 -
        Flags: review?(mak77)

    
    

    
  
This was split apart to be just the places related queries. The interests queries are in bug 864918
Summary: Consolidate interests database queries to PlacesInterestsStorage.jsm module → Consolidate places related needed by interests to PlacesInterestsUtils.jsm module

    
    

    
  


  

        Attachment #740960 -
        Attachment is obsolete: true

        Attachment #740961 -
        Attachment is obsolete: true

        Attachment #798593 -
        Flags: review?(mak77)
Blocks: fxdesktopbacklog
Whiteboard: p=0

    
  

        Attachment #798593 -
        Flags: review?(mak77) → feedback?
No longer blocks: fxdesktopbacklog
Flags: firefox-backlog+

    
    

    
  
I believe we aren't looking to add interests to places soon or at least not in the state proposed in this bug.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → INCOMPLETE

    
  

        Attachment #798593 -
        Flags: feedback?

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: