864933 - Tabs module is too restrictive with appnames

Status: RESOLVED DUPLICATE of bug 855651

(Add-on SDK Graveyard :: General, defect)

Description

[banjo2E]

User Agent: Mozilla/5.0 (Windows NT 6.2; WOW64; rv:20.0) Gecko/20130409 Firefox/20.0 PaleMoon/20.0.1
Build ID: 20130409184116

Steps to reproduce:

I've been running Pale Moon, a Firefox fork, for some months now, and yesterday I noticed one of my addons had stopped working. I checked the console, and it displayed an error with SDK/tabs/tab and several indecipherable lines of code, as did the Mozilla Addon Compatibility Reporter. None of my other addons were doing this. After consulting with the addon developer and the Pale Moon developer, I've been told that this is due to the SDK's tabs module not working unless the browser's appname is exactly Firefox or Fennec.


Actual results:

Copies of the relevant error logs are below.

    Timestamp: 4/22/2013 3:58:21 AM
    Error: betterponymotes: An exception occurred.
    Error: Unsupported Application: The module sdk/tabs/tab currently supports only Firefox, Fennec.
    resource://jid1-thrhdjxskvsicw-at-jetpack/addon-sdk/lib/sdk/loader/cuddlefish.js 80
    Traceback (most recent call last):
      File "resource://gre/modules/NetUtil.jsm", line 140, in NetUtil_asyncOpen/<.onStopRequest
        aCallback(pipe.inputStream, aStatusCode, aRequest);
      File "resource://jid1-thrhdjxskvsicw-at-jetpack/addon-sdk/lib/sdk/net/url.js", line 49, in
        resolve(data);
      File "resource://jid1-thrhdjxskvsicw-at-jetpack/addon-sdk/lib/sdk/core/promise.js", line 143, in resolve
        while (pending.length) result.then.apply(result, pending.shift())
      File "resource://jid1-thrhdjxskvsicw-at-jetpack/addon-sdk/lib/sdk/core/promise.js", line 37, in then
        return { then: function then(resolve) { resolve(value) } }
      File "resource://jid1-thrhdjxskvsicw-at-jetpack/addon-sdk/lib/sdk/core/promise.js", line 117, in resolved
        function resolved(value) { deferred.resolve(resolve(value)) }
      File "resource://jid1-thrhdjxskvsicw-at-jetpack/addon-sdk/lib/sdk/core/promise.js", line 143, in resolve
        while (pending.length) result.then.apply(result, pending.shift())
      File "resource://jid1-thrhdjxskvsicw-at-jetpack/addon-sdk/lib/sdk/core/promise.js", line 37, in then
        return { then: function then(resolve) { resolve(value) } }
      File "resource://jid1-thrhdjxskvsicw-at-jetpack/addon-sdk/lib/sdk/core/promise.js", line 117, in resolved
        function resolved(value) { deferred.resolve(resolve(value)) }
      File "resource://jid1-thrhdjxskvsicw-at-jetpack/addon-sdk/lib/sdk/core/promise.js", line 143, in resolve
        while (pending.length) result.then.apply(result, pending.shift())
      File "resource://jid1-thrhdjxskvsicw-at-jetpack/addon-sdk/lib/sdk/core/promise.js", line 37, in then
        return { then: function then(resolve) { resolve(value) } }
      File "resource://jid1-thrhdjxskvsicw-at-jetpack/addon-sdk/lib/sdk/core/promise.js", line 117, in resolved
        function resolved(value) { deferred.resolve(resolve(value)) }
      File "resource://jid1-thrhdjxskvsicw-at-jetpack/addon-sdk/lib/sdk/core/promise.js", line 143, in resolve
        while (pending.length) result.then.apply(result, pending.shift())
      File "resource://jid1-thrhdjxskvsicw-at-jetpack/addon-sdk/lib/sdk/core/promise.js", line 37, in then
        return { then: function then(resolve) { resolve(value) } }
      File "resource://jid1-thrhdjxskvsicw-at-jetpack/addon-sdk/lib/sdk/core/promise.js", line 117, in resolved
        function resolved(value) { deferred.resolve(resolve(value)) }
      File "resource://jid1-thrhdjxskvsicw-at-jetpack/addon-sdk/lib/sdk/core/promise.js", line 143, in resolve
        while (pending.length) result.then.apply(result, pending.shift())
      File "resource://jid1-thrhdjxskvsicw-at-jetpack/addon-sdk/lib/sdk/core/promise.js", line 37, in then
        return { then: function then(resolve) { resolve(value) } }
      File "resource://jid1-thrhdjxskvsicw-at-jetpack/addon-sdk/lib/sdk/core/promise.js", line 117, in resolved
        function resolved(value) { deferred.resolve(resolve(value)) }
      File "resource://jid1-thrhdjxskvsicw-at-jetpack/addon-sdk/lib/sdk/core/promise.js", line 143, in resolve
        while (pending.length) result.then.apply(result, pending.shift())
      File "resource://jid1-thrhdjxskvsicw-at-jetpack/addon-sdk/lib/sdk/core/promise.js", line 123, in then
        else result.then(resolved, rejected)
      File "resource://jid1-thrhdjxskvsicw-at-jetpack/addon-sdk/lib/sdk/core/promise.js", line 37, in then
        return { then: function then(resolve) { resolve(value) } }
      File "resource://jid1-thrhdjxskvsicw-at-jetpack/addon-sdk/lib/sdk/core/promise.js", line 117, in resolved
        function resolved(value) { deferred.resolve(resolve(value)) }
      File "resource://jid1-thrhdjxskvsicw-at-jetpack/addon-sdk/lib/sdk/core/promise.js", line 55, in effort
        try { return f(options) }
      File "resource://jid1-thrhdjxskvsicw-at-jetpack/addon-sdk/lib/sdk/core/promise.js", line 117, in resolved
        function resolved(value) { deferred.resolve(resolve(value)) }
      File "resource://jid1-thrhdjxskvsicw-at-jetpack/addon-sdk/lib/sdk/core/promise.js", line 143, in resolve
        while (pending.length) result.then.apply(result, pending.shift())
      File "resource://jid1-thrhdjxskvsicw-at-jetpack/addon-sdk/lib/sdk/core/promise.js", line 37, in then
        return { then: function then(resolve) { resolve(value) } }
      File "resource://jid1-thrhdjxskvsicw-at-jetpack/addon-sdk/lib/sdk/core/promise.js", line 117, in resolved
        function resolved(value) { deferred.resolve(resolve(value)) }
      File "resource://jid1-thrhdjxskvsicw-at-jetpack/addon-sdk/lib/sdk/core/promise.js", line 55, in effort
        try { return f(options) }
      File "resource://jid1-thrhdjxskvsicw-at-jetpack/addon-sdk/lib/sdk/addon/runner.js", line 90, in onLocalizationReady
        run(options);
      File "resource://jid1-thrhdjxskvsicw-at-jetpack/addon-sdk/lib/sdk/addon/runner.js", line 122, in run
        let program = main(options.loader, options.main);
      File "resource://jid1-thrhdjxskvsicw-at-jetpack/betterponymotes/lib/main.js", line 13, in
        var page_mod = require("page-mod");
      File "resource://jid1-thrhdjxskvsicw-at-jetpack/addon-sdk/lib/sdk/loader/cuddlefish.js", line 127, in options<.load
        result = load(loader, module);
      File "resource://jid1-thrhdjxskvsicw-at-jetpack/addon-sdk/lib/sdk/page-mod.js", line 14, in
        const { Worker } = require('./content/worker');
      File "resource://jid1-thrhdjxskvsicw-at-jetpack/addon-sdk/lib/sdk/loader/cuddlefish.js", line 127, in options<.load
        result = load(loader, module);
      File "resource://jid1-thrhdjxskvsicw-at-jetpack/addon-sdk/lib/sdk/content/worker.js", line 26, in
        const { getTabForWindow } = require('../tabs/helpers');
      File "resource://jid1-thrhdjxskvsicw-at-jetpack/addon-sdk/lib/sdk/loader/cuddlefish.js", line 127, in options<.load
        result = load(loader, module);
      File "resource://jid1-thrhdjxskvsicw-at-jetpack/addon-sdk/lib/sdk/tabs/helpers.js", line 15, in
        const { Tab } = require('./tab');
      File "resource://jid1-thrhdjxskvsicw-at-jetpack/addon-sdk/lib/sdk/loader/cuddlefish.js", line 133, in options<.load
        error = incompatibility(module) || error;
      File "resource://jid1-thrhdjxskvsicw-at-jetpack/addon-sdk/lib/sdk/loader/cuddlefish.js", line 80, in incompatibility
        " currently supports only " + applications.join(", ") + ".")

    Timestamp: 4/22/2013 3:58:21 AM
    Error: acr: An exception occurred.
    Error: Unsupported Application: The module sdk/tabs/tab currently supports only Firefox, Fennec.
    resource://compatibility-at-addons-dot-mozilla-dot-org/addon-sdk/lib/sdk/loader/cuddlefish.js 80
    Traceback (most recent call last):
      File "resource://gre/modules/NetUtil.jsm", line 140, in NetUtil_asyncOpen/<.onStopRequest
        aCallback(pipe.inputStream, aStatusCode, aRequest);
      File "resource://compatibility-at-addons-dot-mozilla-dot-org/addon-sdk/lib/sdk/net/url.js", line 49, in
        resolve(data);
      File "resource://compatibility-at-addons-dot-mozilla-dot-org/addon-sdk/lib/sdk/core/promise.js", line 143, in resolve
        while (pending.length) result.then.apply(result, pending.shift())
      File "resource://compatibility-at-addons-dot-mozilla-dot-org/addon-sdk/lib/sdk/core/promise.js", line 37, in then
        return { then: function then(resolve) { resolve(value) } }
      File "resource://compatibility-at-addons-dot-mozilla-dot-org/addon-sdk/lib/sdk/core/promise.js", line 117, in resolved
        function resolved(value) { deferred.resolve(resolve(value)) }
      File "resource://compatibility-at-addons-dot-mozilla-dot-org/addon-sdk/lib/sdk/core/promise.js", line 143, in resolve
        while (pending.length) result.then.apply(result, pending.shift())
      File "resource://compatibility-at-addons-dot-mozilla-dot-org/addon-sdk/lib/sdk/core/promise.js", line 37, in then
        return { then: function then(resolve) { resolve(value) } }
      File "resource://compatibility-at-addons-dot-mozilla-dot-org/addon-sdk/lib/sdk/core/promise.js", line 117, in resolved
        function resolved(value) { deferred.resolve(resolve(value)) }
      File "resource://compatibility-at-addons-dot-mozilla-dot-org/addon-sdk/lib/sdk/core/promise.js", line 143, in resolve
        while (pending.length) result.then.apply(result, pending.shift())
      File "resource://compatibility-at-addons-dot-mozilla-dot-org/addon-sdk/lib/sdk/core/promise.js", line 37, in then
        return { then: function then(resolve) { resolve(value) } }
      File "resource://compatibility-at-addons-dot-mozilla-dot-org/addon-sdk/lib/sdk/core/promise.js", line 117, in resolved
        function resolved(value) { deferred.resolve(resolve(value)) }
      File "resource://compatibility-at-addons-dot-mozilla-dot-org/addon-sdk/lib/sdk/core/promise.js", line 143, in resolve
        while (pending.length) result.then.apply(result, pending.shift())
      File "resource://compatibility-at-addons-dot-mozilla-dot-org/addon-sdk/lib/sdk/core/promise.js", line 37, in then
        return { then: function then(resolve) { resolve(value) } }
      File "resource://compatibility-at-addons-dot-mozilla-dot-org/addon-sdk/lib/sdk/core/promise.js", line 117, in resolved
        function resolved(value) { deferred.resolve(resolve(value)) }
      File "resource://compatibility-at-addons-dot-mozilla-dot-org/addon-sdk/lib/sdk/core/promise.js", line 143, in resolve
        while (pending.length) result.then.apply(result, pending.shift())
      File "resource://compatibility-at-addons-dot-mozilla-dot-org/addon-sdk/lib/sdk/core/promise.js", line 37, in then
        return { then: function then(resolve) { resolve(value) } }
      File "resource://compatibility-at-addons-dot-mozilla-dot-org/addon-sdk/lib/sdk/core/promise.js", line 117, in resolved
        function resolved(value) { deferred.resolve(resolve(value)) }
      File "resource://compatibility-at-addons-dot-mozilla-dot-org/addon-sdk/lib/sdk/core/promise.js", line 143, in resolve
        while (pending.length) result.then.apply(result, pending.shift())
      File "resource://compatibility-at-addons-dot-mozilla-dot-org/addon-sdk/lib/sdk/core/promise.js", line 123, in then
        else result.then(resolved, rejected)
      File "resource://compatibility-at-addons-dot-mozilla-dot-org/addon-sdk/lib/sdk/core/promise.js", line 37, in then
        return { then: function then(resolve) { resolve(value) } }
      File "resource://compatibility-at-addons-dot-mozilla-dot-org/addon-sdk/lib/sdk/core/promise.js", line 117, in resolved
        function resolved(value) { deferred.resolve(resolve(value)) }
      File "resource://compatibility-at-addons-dot-mozilla-dot-org/addon-sdk/lib/sdk/core/promise.js", line 55, in effort
        try { return f(options) }
      File "resource://compatibility-at-addons-dot-mozilla-dot-org/addon-sdk/lib/sdk/core/promise.js", line 117, in resolved
        function resolved(value) { deferred.resolve(resolve(value)) }
      File "resource://compatibility-at-addons-dot-mozilla-dot-org/addon-sdk/lib/sdk/core/promise.js", line 143, in resolve
        while (pending.length) result.then.apply(result, pending.shift())
      File "resource://compatibility-at-addons-dot-mozilla-dot-org/addon-sdk/lib/sdk/core/promise.js", line 37, in then
        return { then: function then(resolve) { resolve(value) } }
      File "resource://compatibility-at-addons-dot-mozilla-dot-org/addon-sdk/lib/sdk/core/promise.js", line 117, in resolved
        function resolved(value) { deferred.resolve(resolve(value)) }
      File "resource://compatibility-at-addons-dot-mozilla-dot-org/addon-sdk/lib/sdk/core/promise.js", line 55, in effort
        try { return f(options) }
      File "resource://compatibility-at-addons-dot-mozilla-dot-org/addon-sdk/lib/sdk/addon/runner.js", line 90, in onLocalizationReady
        run(options);
      File "resource://compatibility-at-addons-dot-mozilla-dot-org/addon-sdk/lib/sdk/addon/runner.js", line 122, in run
        let program = main(options.loader, options.main);
      File "resource://compatibility-at-addons-dot-mozilla-dot-org/acr/lib/main.js", line 7, in
        const chromeMod = require("chrome-mod");
      File "resource://compatibility-at-addons-dot-mozilla-dot-org/addon-sdk/lib/sdk/loader/cuddlefish.js", line 127, in options<.load
        result = load(loader, module);
      File "resource://compatibility-at-addons-dot-mozilla-dot-org/acr/lib/chrome-mod.js", line 8, in
        const { Worker, Loader } = require('api-utils/content');
      File "resource://compatibility-at-addons-dot-mozilla-dot-org/addon-sdk/lib/sdk/loader/cuddlefish.js", line 127, in options<.load
        result = load(loader, module);
      File "resource://compatibility-at-addons-dot-mozilla-dot-org/addon-sdk/lib/sdk/content/content.js", line 13, in
        exports.Symbiont = require('./symbiont').Symbiont;
      File "resource://compatibility-at-addons-dot-mozilla-dot-org/addon-sdk/lib/sdk/loader/cuddlefish.js", line 127, in options<.load
        result = load(loader, module);
      File "resource://compatibility-at-addons-dot-mozilla-dot-org/addon-sdk/lib/sdk/content/symbiont.js", line 12, in
        const { Worker } = require('./worker');
      File "resource://compatibility-at-addons-dot-mozilla-dot-org/addon-sdk/lib/sdk/loader/cuddlefish.js", line 127, in options<.load
        result = load(loader, module);
      File "resource://compatibility-at-addons-dot-mozilla-dot-org/addon-sdk/lib/sdk/content/worker.js", line 26, in
        const { getTabForWindow } = require('../tabs/helpers');
      File "resource://compatibility-at-addons-dot-mozilla-dot-org/addon-sdk/lib/sdk/loader/cuddlefish.js", line 127, in options<.load
        result = load(loader, module);
      File "resource://compatibility-at-addons-dot-mozilla-dot-org/addon-sdk/lib/sdk/tabs/helpers.js", line 15, in
        const { Tab } = require('./tab');
      File "resource://compatibility-at-addons-dot-mozilla-dot-org/addon-sdk/lib/sdk/loader/cuddlefish.js", line 133, in options<.load
        error = incompatibility(module) || error;
      File "resource://compatibility-at-addons-dot-mozilla-dot-org/addon-sdk/lib/sdk/loader/cuddlefish.js", line 80, in incompatibility
        " currently supports only " + applications.join(", ") + ".")



Expected results:

Ideally, these two addons should be working normally; Pale Moon uses Firefox's code base and has all of its resources, so compatibility shouldn't be an issue.

Comment 1

[Erik Vold [:erikvold] (please needinfo? me)]

This change was made in bug 725409, Matteo want to chime in here?

Comment 2

[Matteo Ferretti [:zer0] [:matteo]]

In bug 725409 we introduce a new feature to specify the app compatibility per module; however this check introduced a regression where the `name` has to be exactly the one specified, instead of the GUID, therefore all the re-branded product gives this error.

That should be now fixed in bug 855651. I will mark this as duplicated.