The default bug view has changed. See this FAQ.

Add Google Analytics parameters to default snippet links

RESOLVED FIXED in Firefox 23

Status

()

Firefox
General
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: Winston Bowden, Assigned: mkelly)

Tracking

Trunk
Firefox 23
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

4 years ago
The default snippets that run when the service is down are using webtrends tags.  Can we update those with GA?  

I can't see the add-on snippet at the moment, but I believe the other snippet links to the feature page.  I created a GA link for you.  The add-ons will need a GA link as well.  

Feature default snippet GA link:
https://www.mozilla.org/en-US/firefox/features/?utm_source=snippet&utm_medium=snippet&utm_campaign=default+feature+snippet
(Assignee)

Comment 1

4 years ago
The two current URLs being used are:

http://www.mozilla.com/firefox/features/?WT.mc_ID=default1
https://addons.mozilla.org/firefox/?src=snippet&WT.mc_ID=default2

I'll change the first one to

http://www.mozilla.com/firefox/features/?utm_source=snippet&utm_medium=snippet&utm_campaign=default+feature+snippet

What should the second one be?

I've got mozilla-central set up locally and I've successfully changed the URLs. Once I make the change and have a patch I'll move this over to the right component and get someone to review/commit my changes.
(Reporter)

Comment 2

4 years ago
Thanks.  Add-ons link would be:
https://addons.mozilla.org/firefox/?utm_source=snippet&utm_medium=snippet&utm_campaign=addons
(Assignee)

Updated

4 years ago
Assignee: wbowden → nobody
Component: Campaign → General
Product: Snippets → Firefox
Summary: Default snippets that show when service is down → Add Google Analytics parameters to default snippet links
(Assignee)

Comment 3

4 years ago
Created attachment 743290 [details] [diff] [review]
patch v1

Here's a patch that makes the requested changes.

fryn: Let me know if I did something wrong and what else I need to do to get this merged, I've never touched the browser before. :D
Attachment #743290 - Flags: review?(fyan)
(Assignee)

Updated

4 years ago
Assignee: nobody → mkelly

Comment 4

4 years ago
Comment on attachment 743290 [details] [diff] [review]
patch v1

>+  "http://www.mozilla.com/firefox/features/?utm_source=snippet&utm_medium=snippet&utm_campaign=default+feature+snippet"

I think this should be:
https://www.mozilla.org/firefox/features/?utm_source=snippet&utm_medium=snippet&utm_campaign=default+feature+snippet
(Assignee)

Comment 5

4 years ago
Created attachment 743590 [details] [diff] [review]
patch v1.1

Link has been httpsified!
Attachment #743290 - Attachment is obsolete: true
Attachment #743290 - Flags: review?(fyan)
Attachment #743590 - Flags: review?(fyan)

Comment 6

4 years ago
Comment on attachment 743590 [details] [diff] [review]
patch v1.1

>+  "https://www.mozilla.com/firefox/features/?utm_source=snippet&utm_medium=snippet&utm_campaign=default+feature+snippet"

Do we actually want the mozilla.com to mozilla.org redirect?
(Assignee)

Comment 7

4 years ago
Created attachment 743679 [details] [diff] [review]
patch v1.2

Clearly I am not on my A-game today. I've tested both the URLs to ensure only an l10n redirect happens. Hopefully I haven't missed anything again. :D
Attachment #743590 - Attachment is obsolete: true
Attachment #743590 - Flags: review?(fyan)
Attachment #743679 - Flags: review?(fyan)

Updated

4 years ago
Attachment #743679 - Attachment is patch: true
Attachment #743679 - Attachment mime type: text/x-patch → text/plain

Comment 8

4 years ago
Comment on attachment 743679 [details] [diff] [review]
patch v1.2

Thanks for working on this, mkelly. :)
Attachment #743679 - Flags: review?(fyan) → review+

Comment 9

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/d024e275689a
Status: NEW → ASSIGNED
OS: Mac OS X → All
Hardware: x86 → All
Target Milestone: --- → Firefox 23
Version: unspecified → Trunk
https://hg.mozilla.org/mozilla-central/rev/d024e275689a
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
See Also: → bug 964539
You need to log in before you can comment on or make changes to this bug.