Closed Bug 864948 Opened 7 years ago Closed 7 years ago

metrotestharness bins built with pgo builds have a dependency on PGORT100.DLL

Categories

(Firefox for Metro Graveyard :: Tests, defect)

x86_64
Windows 8.1
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 23

People

(Reporter: jimm, Assigned: jimm)

References

Details

Attachments

(1 file, 2 obsolete files)

Not sure what the deal is here. We specify that this exe isn't supposed to get pgo treatment - 

http://mxr.mozilla.org/mozilla-central/source/browser/metro/shell/testing/Makefile.in#13

Yet for some reason the zips of test related files -

http://mxr.mozilla.org/mozilla-central/source/testing/mochitest/Makefile.in#151

get an exe that links to a pgo dll.
Summary: metrotestharness bins build with pgo builds have a dependency on PGORT100.DLL → metrotestharness bins built with pgo builds have a dependency on PGORT100.DLL
Attached patch fix (obsolete) — Splinter Review
Assignee: nobody → jmathies
Attached patch fix (obsolete) — Splinter Review
those directives needed to be above config.mk.
Attachment #741253 - Attachment is obsolete: true
Attachment #741266 - Flags: review?(mh+mozilla)
ah, NO_PROFILE_GUIDED_OPTIMIZE need to be above it too.
Attached patch fixSplinter Review
Attachment #741266 - Attachment is obsolete: true
Attachment #741266 - Flags: review?(mh+mozilla)
Attachment #741269 - Flags: review?(mh+mozilla)
Comment on attachment 741269 [details] [diff] [review]
fix

Review of attachment 741269 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/metro/shell/testing/Makefile.in
@@ +13,5 @@
> +USE_STATIC_LIBS = 1
> +
> +# don't use moz glue libs
> +MOZ_GLUE_LDFLAGS =
> +MOZ_GLUE_PROGRAM_LDFLAGS =

do you really want that?
Attachment #741269 - Flags: review?(mh+mozilla) → review+
(In reply to Mike Hommey [:glandium] from comment #5)
> Comment on attachment 741269 [details] [diff] [review]
> fix
> 
> Review of attachment 741269 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: browser/metro/shell/testing/Makefile.in
> @@ +13,5 @@
> > +USE_STATIC_LIBS = 1
> > +
> > +# don't use moz glue libs
> > +MOZ_GLUE_LDFLAGS =
> > +MOZ_GLUE_PROGRAM_LDFLAGS =
> 
> do you really want that?

USE_STATIC_LIBS is good since it keeps us from be dependent on crt libs. For the xpcom glue stuff, we don't use any of that in this app, so no need to link to it.
(In reply to Jim Mathies [:jimm] from comment #6)
> (In reply to Mike Hommey [:glandium] from comment #5)
> > Comment on attachment 741269 [details] [diff] [review]
> > fix
> > 
> > Review of attachment 741269 [details] [diff] [review]:
> > -----------------------------------------------------------------
> > 
> > ::: browser/metro/shell/testing/Makefile.in
> > @@ +13,5 @@
> > > +USE_STATIC_LIBS = 1
> > > +
> > > +# don't use moz glue libs
> > > +MOZ_GLUE_LDFLAGS =
> > > +MOZ_GLUE_PROGRAM_LDFLAGS =
> > 
> > do you really want that?
> 
> USE_STATIC_LIBS is good since it keeps us from be dependent on crt libs. For
> the xpcom glue stuff, we don't use any of that in this app, so no need to
> link to it.

mozglue is not xpcom glue, and it contains jemalloc among other things. FWIW
https://hg.mozilla.org/mozilla-central/rev/c3e362c2769c
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
OS: Windows 8 Metro → Windows 8.1
You need to log in before you can comment on or make changes to this bug.