864952 - Thumbnail field should not be required in MakeAPI

Status: RESOLVED FIXED

(Webmaker Graveyard :: MakeAPI, defect)

Description

[inactivate account for kate]

After going over the requirements for different types of makes, I don't think it makes sense to require the thumbnail field.

One example is Event makes, which may be represented by a typographical solution, or a UI element created inside by the gallery -- it doesn't make sense to require a thumbnail. 

Requiring the tool to pass in a default thumbnail to be stored in the MakeAPI also makes it much harder to change later, compared to reading the make type and inside our gallery UI elements.

Comment 1

[Scott [:thecount] Downe]

Attachment: https://github.com/mozilla/MakeAPI/pull/30

Comment 2

[Matthew Schranz [:mjschranz]]

Comment on attachment 741287 [details]
https://github.com/mozilla/MakeAPI/pull/30

Sorry for getting to this so late, but we are going to have to address what I brought up in the comment.

Comment 3

[Scott [:thecount] Downe]

Comment on attachment 741287 [details]
https://github.com/mozilla/MakeAPI/pull/30

Updated.

I agree with this change. Things are falling into place regarding the API.

Comment 4

[Scott [:thecount] Downe]

Staged: https://github.com/mozilla/MakeAPI/commit/e00ed0efe23868dcb5d3b585832b0c241c73f925