After going over the requirements for different types of makes, I don't think it makes sense to require the thumbnail field. One example is Event makes, which may be represented by a typographical solution, or a UI element created inside by the gallery -- it doesn't make sense to require a thumbnail. Requiring the tool to pass in a default thumbnail to be stored in the MakeAPI also makes it much harder to change later, compared to reading the make type and inside our gallery UI elements.
Comment on attachment 741287 [details] https://github.com/mozilla/MakeAPI/pull/30 Sorry for getting to this so late, but we are going to have to address what I brought up in the comment.
Attachment #741287 - Flags: review?(schranz.m) → review-
Comment on attachment 741287 [details] https://github.com/mozilla/MakeAPI/pull/30 Updated. I agree with this change. Things are falling into place regarding the API.
Attachment #741287 - Flags: review- → review?(schranz.m)
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.