864967 - Event makes should be sortable by event date

Status: RESOLVED INVALID

(Webmaker Graveyard :: MakeAPI, defect)

Description

[inactivate account for kate]

Event-type makes that will appear in the "Party" section will have a date (or a date-range, for multi-day events) referring to when the event will occur. We need a way to search for events ordered by that date.

Creating a new field for this seems like overkill, since it will not apply to other types of makes -- will we be able to handle this with a tag prefix, and still be able to sort by that tag prefix?

Example use cases:

- On the "Party" page, display the 30 events closest to the current date.
- Search for the 10 most recent events with the word "kittens" that have already taken place

Comment 1

[Matthew Schranz [:mjschranz]]

I'm going to bring the discussions I've had with :humph into this ticket since it seems like the best place to introduce it all.

We have had tickets back and forth about required fields or adding in new fields to help deal with events and it's been hard to figure out a good way to do this while keeping the idea of a "Make" as simple as possible. The original solution to this was the tagging system since in theory we could do whatever we wanted here. However really it proved to be quite difficult to fit things in here.

We decided that rather than trying to shove events into the same system that it would be beneficial to separate them out and leave them with their own Mongo Schema and ElasticSearch index/mapping. This allows us to keep Events very specific to our need.

I've done a lot of the ground work here. The work we have done with the MakeAPI itself is fluid enough that it's easy to add on bits without bloating everything else while still keeping it easy enough to use. See the following branch https://github.com/mjschranz/MakeAPI/tree/partyapi

What I need is feedback on the kind of information we need for events/party. Or even if people think this is a dumb idea.

Comment 2

[Brett Gaylor [:brett]]

Hmmm.  Do we think that whatever app we build to create events will use the MakeAPI?  Do we need them to be "makes"?

Comment 3

[Matthew Schranz [:mjschranz]]

They don't need to be makes. Right now the test pages I have created use the makeapi as it's easy enough to add in accessible points to them.

Maybe it doesn't need to be called MakeAPI? I don't know, I wanted to get some start here and see where it goes. I did this based off the discussion I had with :humph which he said he had a similar discussion with Beltzner.

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

I'm not a qualified developer, but all my instincts scream that trying to turn the MakeAPI / data schema into the be all and end all for all objects in your system is a great way to recreate XML or JSON, at which point, just use XML or JSON.

Comment 5

[David Humphrey (:humph)]

I need more context on where we've landed with the events stuff since last week.  I think that I want to pause this until it's clear how we're moving.

Comment 6

[Cassie McDaniel [:cassiemc]]

The prd has been updated, and that is what I am basing second pass wireframes on (which I hope to share tomorrow). https://etherpad.mozilla.org/webmakerv2prd

Comment 7

[Simon C. Wex]

Event !== Make

These don't belong in the MakeAPI.

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

I'm going to resolve this as INVALID as it seems pretty clear that we're not interested in forcing event data objects into the MakeAPI.

Re-open if that's a misinterpretation.