864972 - Crash [@ nsFrameManager::ReResolveStyleContext] with -moz-column, floating first-letter

Status: RESOLVED WORKSFORME

(Core :: Layout, defect)

Description

[Jesse Ruderman]

Attachment: testcase (crashes Firefox when loaded)

Comment 1

[Jesse Ruderman]

Attachment: assertions & stack

Comment 2

[Scoobidiver (away)]

On Windows: bp-0bd30a61-54d7-4ef9-a3e7-07f062130423.

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Closing because no crash reported since 12 weeks.

Comment 4

[Mats Palmgren (inactive)]

Sylvestre, please mark bugs that have testcases with in-testsuite? when closing them.
(or, ideally, land the testcase and mark it in-testsuite+)

(I'm assuming that you've actually tested all these bugs you're closing...)

Comment 5

[Mats Palmgren (inactive)]

Please also note that some bugs needs to be tested in a debug build,
since they are about failing assertions.

Comment 6

[Sylvestre Ledru [:Sylvestre]]

Yeah, we are going to update the script to fix that.

Comment 7

[Mats Palmgren (inactive)]

Who are "we" in that statement?
Did you coordinate this effort with the module owners of the components
you plan to auto-resolve bugs in?
Was the script reviewed by all stake holders?

In case you're not aware, we've had a few incidents in the past where
such efforts have gone wrong and we had to restore a lot bugs afterwards,
so I'm a little concerned to see such scripts being let loose again...

Comment 8

[Sylvestre Ledru [:Sylvestre]]

We (release management team) have been doing crash triage for several years now.

We missed the testcase keyword. Sorry about that.
For this bug, I would have wontfixed this one by hand. No action for 5 years...

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(In reply to Sylvestre Ledru [:sylvestre] from comment #8)
> For this bug, I would have wontfixed this one by hand. No action for 5
> years...

That's not an acceptable reason to wontfix a bug.

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

While other resolutions may be appropriate, wontfix is not an appropriate resolution for a crash bug with a testcase.

Comment 11

[Mats Palmgren (inactive)]

(In reply to Sylvestre Ledru [:sylvestre] from comment #8)
> We (release management team) have been doing crash triage for several years
> now.

We appreciate that, but it's an entirely different thing to let
loose a script to make these decisions.  You need to be more careful
with that and definitely plan this together with the teams involved
(for Layout* components - the Layout team).

It was just a few months ago that a similar experiment failed:
https://groups.google.com/d/msg/mozilla.dev.platform/L_iz6dqFIYU/FP_ehB_rCQAJ

Personally, I tend to think that Layout bugs MUST be resolved by
a human because the considerations when doing that is not something
that can be automated easily, with very few exceptions (bugs filed
from Socorro that only has one comment perhaps).

We could try to automate flagging some old bugs that may need retriage
so that a human can look at them and decide what to do perhaps.  Again,
this is something that should be done in cooperation with the affected
teams IMO.

Comment 12

[Andrei Purice]

Following the reporter's steps I am able to confirm that the issues doesn't happen anymore on Window 10x64 or MacOs 10.15 on any of the current versions of Firefox Nightly 87.0a1 (2021-02-15), beta 86.0 and release 85.0.2. The example test case doesn't crash Firefox anymore.

Closing this issue as Resolved > Worksforme.
Feel free to re-open or file a new bug if this issue reoccurs again.

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

Since the bug is closed, the stalled keyword is now meaningless.
For more information, please visit auto_nag documentation.