Closed Bug 864986 Opened 11 years ago Closed 11 years ago

Disposable should guard against multiple calls to destroy

Categories

(Add-on SDK Graveyard :: General, defect)

x86_64
Windows 7
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mossop, Assigned: mossop)

References

Details

Attachments

(1 file)

If you call destroy() twice on a Disposable then it attempts to destroy twice, that breaks in some cases. Disposable should guard against this.
Assignee: nobody → dtownsend+bugmail
Attachment #741020 - Flags: review?(rFobic)
Blocks: 792636
Attachment #741020 - Flags: review?(rFobic) → review+
Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/833889e4fd7011f71320852c79ae165ae49c1009
Bug 864986: Ignore multiple calls to a Disposable's destroy method.

https://github.com/mozilla/addon-sdk/commit/b4c092e9eecec93e25fec72c8c9d99cf6983fd98
Merge pull request #963 from Mossop/bug864986

Bug 864986: Ignore multiple calls to a Disposable's destroy method. r=gozala
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: