865056 - Change current time while playing with the Youtube player causes loop

Status: RESOLVED WORKSFORME

(Webmaker Graveyard :: popcorn.js, defect)

Description

[arnaud]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_8_3) AppleWebKit/537.31 (KHTML, like Gecko) Chrome/26.0.1410.65 Safari/537.31

Steps to reproduce:

Load a youtube video, via the smart player.

Play it, manually.

Change the current time, while playing, programmatically.


Actual results:

The video is looping, sometimes during few seconds, sometimes endlessly


Expected results:

No loop, go to the right time and continue if playing or wait for play it paused.

Comment 1

[Scott [:thecount] Downe]

I setup a test for this, using the newest version of popcorn.

It is fixed. I suspect this was an issue back in 1.3, but we tagged a 1.4 yesterday which is going to fix this.

I used this as a test:

<script src="popcorn.js"></script>
<script src="modules/player/popcorn.player.js"></script>
<script src="wrappers/common/popcorn._MediaElementProto.js"></script>
<script src="wrappers/youtube/popcorn.HTMLYouTubeVideoElement.js"></script>
<script src="players/youtube/popcorn.youtube.js"></script>

<div style="height: 200px; width: 200px;" id="video"></div>
<button id="seek">seek to</button>
<button id="playAndSeek">play and seek to</button></br>
<input id="timeInput" value="20"></input></br>
<button id="play">play</button>
<button id="pause">pause</button>
<script>
  var p = Popcorn.smart( "#video", "http://www.youtube.com/watch?v=QZB7OFRUrA0" );

  var timeInput = document.getElementById( "timeInput" );
  var seekButton = document.getElementById( "seek" );
  seekButton.addEventListener( "click", function() {
    p.currentTime( timeInput.value );
  }, false );

  var playButton = document.getElementById( "play" );
  playButton.addEventListener( "click", function() {
    p.play();
  }, false );

  var pauseButton = document.getElementById( "pause" );
  pauseButton.addEventListener( "click", function() {
    p.pause();
  }, false );

  var playAndSeekButton = document.getElementById( "playAndSeek" );
  playAndSeekButton.addEventListener( "click", function() {
    p.play( timeInput.value );
  }, false );
</script>

We can reopen the bug if this doesn't fix it.