865065 - allow makeRemote() on window targets

Status: NEW

(DevTools :: Framework, defect)

Description

[Heather Arthur [:harth]]

Opening a devtools window to debug a browser window (running this scratchpad: https://gist.github.com/harthur/5448267), and I get this error in the error console:

Error: TypeError: this.target.makeRemote is not a function
Source File: resource://app/modules/devtools/ProfilerPanel.jsm
Line: 302

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Does this still happen? I can't reproduce it on Linux.

Comment 2

[Heather Arthur [:harth]]

Yeah, still getting this on a pull from today. None of the remote-able tools work on non-tabs and "this.target.makeRemote is not a function" errors from all the tools.

Comment 3

[Girish Sharma [:Optimizer]]

Because the method makeRemote which is present for TabTarget (line 254 of target.js) is missing from WindowTarget. I don't know how it will be implemented, as the makeRemote method assumes that a tab is being attached.

But there is another way of opening toolbox for the window in Nightly : 
>> listen 6666
(or any other number)

Tools > Developer > Connect.. 
type 6666 in the port, localhost in host, connect. Accept the incoming connection, and you are done. All remoteable tools should work

Comment 4

[Heather Arthur [:harth]]

It would be great to be able to inspect other windows as well (e.g. the devtools window itself).

We probably shouldn't have a `WindowTarget` if none of the tools work with it.

Comment 5

[Panos Astithas (he/him) [:past] (please ni?)]

Assuming WindowTarget is still useful, the plan was to fold it into TabTarget at some point, the same way we did with RemoteTarget. I can't find a bug for that, so we could use this one for tracking that work.

Comment 7

[Dave Camp (:dcamp)]

Attachment: WIP 1

This incomplete patch restores the use of the window target for toplevel windows.

It works by exposing toplevel windows as tabs over the debugging protocol when the devtools.chrome.enabled pref is set.

I haven't put much testing into it.

To use the gist in https://gist.github.com/harthur/5447846 you need to open your toolbox in its own window (not docked), and change:


let win = toolbox._host.frame.contentWindow;

to 

let win = toolbox._host._window;

Comment 8

[Dave Camp (:dcamp)]

This patch seems to trigger a windowMediator list deadlock as it is.

Comment 9

[Dave Camp (:dcamp)]

Attachment: WIP 2

This adds a really goofy hack that lets you debug any window (not just toplevels).

This also comments out a line I needed to comment out in the style editor, I'm not sure what's up with it, but things were hanging with that still in.

Comment 10

[Dave Camp (:dcamp)]

WIP 2 also fixes the deadlock.

Comment 11

[Dave Camp (:dcamp)]

Attachment: WIP 2.1

This time actually folding in the described changes.

Comment 12

[Dave Camp (:dcamp)]

Attachment: v1

This removes the hack for non-toplevel windows, but should work otherwise.

Comment 13

[Dave Camp (:dcamp)]

Comment on attachment 779538 [details] [diff] [review]
v1

This blew up on try, removing r? for now.