Limit doesn't work for "find" method

RESOLVED FIXED

Status

Webmaker
MakeAPI
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: inactivate account for kate, Assigned: mjschranz)

Tracking

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Limit doesn't seem to be applied when I run the following code:

make.find({
  tags: {
    tags: "featured",
    execution: "bool"
  }
}).limit( 30 ).then( function( data )  {
   console.log( data );
});

Expected: 30 results
Actual: All results
(Reporter)

Comment 1

5 years ago
Wait sorry, wrong code:

make.find({
  tags: {
    tags: searchInput.value.split(","),
    execution: "bool"
  },
  limit: 30
}).then( function( data )  {
  console.log( data );
});


Actual: Error
Comment on attachment 741297 [details]
https://github.com/mozilla/MakeAPI/pull/31/files

Question in the pull request.

A bit of a nit, but if we could fix would be nice.

P+ with that.
Attachment #741297 - Flags: review?(scott) → review-
(Assignee)

Comment 4

5 years ago
Comment on attachment 741297 [details]
https://github.com/mozilla/MakeAPI/pull/31/files

Replied to your comment.

I'm already doing what you asked.
Attachment #741297 - Flags: review- → review?(scott)
(Assignee)

Comment 5

5 years ago
Actually, I was wrong. Figured out what Scott meant. Pushed up more changes.
Status: NEW → ASSIGNED
(Assignee)

Comment 7

5 years ago
Staged on master: https://github.com/mozilla/MakeAPI/commit/62cb47b89103da26d7e7ba91e320202e8ed1b6ec
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.