865086 - opening chat in minimized mode still sets the new chat as selected

Status: RESOLVED WONTFIX

(Firefox Graveyard :: SocialAPI, defect)

Description

[Shane Caraveo (:mixedpuppy)]

In fixing bug 864505 I discovered that we set new minimized chat windows as selected, see chatbar.openChat.  The fix is not entirely trivial as I think selectedChat==focusedChat, but maybe not, and minimized chats should never be selected.

Comment 1

[Mark Hammond [:markh] [:mhammond]]

(In reply to Shane Caraveo (:mixedpuppy) from comment #0)
> The fix is not entirely trivial as I think
> selectedChat==focusedChat, but maybe not, and minimized chats should never
> be selected.

Yeah, this is tricky.  IIUC, minimized chats will need to be focusable so that keyboard navigation can be used to act on one of them.  Also, if only minimized chats are open, it might make sense for one to be the "selected" chat, so the keyboard shortcut to "focus chats" does *something* sane.  But having a chat be focused when it isn't the selected chat doesn't make sense in the same way that having a chat be selected but not focused doesn't.

I wonder if we need to step back and see if selectedChat makes sense at all as a separate concept from "the focused chat"

Comment 2

[Shane Caraveo (:mixedpuppy)]

deprecation in fx51