[sms] The user can still enter characters in the input while the alert is shown, even when it's supposed to be full

VERIFIED FIXED

Status

Firefox OS
Gaia::SMS
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: julienw, Assigned: julienw)

Tracking

unspecified
x86_64
Linux

Firefox Tracking Flags

(blocking-b2g:tef+, b2g18 verified, b2g18-v1.0.1 verified)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
In tef+ bug 843511 I disabled entering more characters when we reached a limit (10 segments). However, due to Bug 863466, the keyboard is not dismissed when we show an alert box (see screenshots there), and so the user can still use the keyboard. As a result, more characters can be written to the input because we haven't disabled entering more characters yet, and when the user comes back to the message composing window, the alert will be displayed every time the user presses "back".

This is less than optimal.

Since this is a follow up to tef+ bug 843511 and the fix is very easy and small (set the maxlength limitation prior triggering the alert box) I'd like to please tef+ this bug.

A patch is coming.
(Assignee)

Comment 1

5 years ago
Created attachment 741207 [details] [diff] [review]
patch v1

---
 apps/sms/js/thread_ui.js |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

see also PR https://github.com/mozilla-b2g/gaia/pull/9370
Assignee: nobody → felash
Attachment #741207 - Flags: review?(fbsc)
(Assignee)

Comment 2

5 years ago
it seems like we'll backout bug 843511 after all so please disregard this bug for now...
Status: NEW → RESOLVED
blocking-b2g: tef? → ---
Last Resolved: 5 years ago
Resolution: --- → WONTFIX
(Assignee)

Updated

5 years ago
Attachment #741207 - Flags: review?(fbsc)
(Assignee)

Comment 3

5 years ago
reopening this after all.

We're supposed to do the feature of Bug 843511 again and differently in Bug 865411, but I don't know yet if that bug will be tef+.

Therefore, I'm nominating this bug to fix the implementation done in Bug 843511. Triagers, please tef+ this bug if you don't tef+ Bug 865411. _If_ you tef+ Bug 865411, we can close this bug WONTFIX.

See comment 0 for the rationale about why this bug should be tef+ (very low risk, very short patch, good value).
Status: RESOLVED → REOPENED
blocking-b2g: --- → tef?
Resolution: WONTFIX → ---
(Assignee)

Comment 4

5 years ago
Comment on attachment 741207 [details] [diff] [review]
patch v1

Borja, I'd appreciate that you take 5 minutes to review this bug ;)

Thanks
Attachment #741207 - Flags: review?(fbsc)
Taking a look!
Comment on attachment 741207 [details] [diff] [review]
patch v1

Review of attachment 741207 [details] [diff] [review]:
-----------------------------------------------------------------

::: apps/sms/js/thread_ui.js
@@ +248,5 @@
>  
>      // note: when we'll have the MMS feature, we'll want to use an MMS instead
>      // of forbidding this.
>      if (hasMaxLength) {
> +      // set maxlength before calling alert, to disable entering more characters

Please add 'this.input.blur();' to this line in order to avoid the horrible mix of an 'alert' and 'keyboard' at the same time.
(Assignee)

Comment 7

5 years ago
Created attachment 742302 [details] [diff] [review]
patch v2

Addressed the comment.

---
 apps/sms/js/thread_ui.js |    7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

see also PR https://github.com/mozilla-b2g/gaia/pull/9370
Attachment #741207 - Attachment is obsolete: true
Attachment #741207 - Flags: review?(fbsc)
Attachment #742302 - Flags: review?(fbsc)
Comment on attachment 742302 [details] [diff] [review]
patch v2

There are some scenarios to polish, but we need UX input and will be fixed in MMS. Thanks!
Attachment #742302 - Flags: review?(fbsc) → review+
(Assignee)

Comment 9

5 years ago
master: b742c91a1629d90067af454c4bef1e7480cc67d5
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED

Updated

5 years ago
blocking-b2g: tef? → tef+
status-b2g18: --- → affected
status-b2g18-v1.0.1: --- → affected
Uplifted b742c91a1629d90067af454c4bef1e7480cc67d5 to:
v1-train: 9a3b4cf49c82a2f5fcba1f6fc72d4cdbe350c6d2
v1.0.1: a92bfdf07eee2833a097ee7b7338bbee269bda51
status-b2g18: affected → fixed
status-b2g18-v1.0.1: affected → fixed

Comment 11

5 years ago
Issue is not reproducing on Inari. The text box is not allowing user to enter the characters once after reaching the limit and displays a message as expected.

Inari Build ID: 20130506070205
Kernel Date: Feb 21
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/ce67220b877d
Gaia: 1e598d8842920d9e0b1743dc6fe9390bd5f6e2df

Issue is not reproducing on Leo. The text box is not allowing user to enter the characters once after reaching the limit and displays a message as expected.

Leo Build ID: 20130503070204
Environmental  Variables:
Kernel Date: Apr 25
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/8becaf2a0bc7
Gaia: b0aca0dd1e2955e11190ede725e1fb9ee596438b
Status: RESOLVED → VERIFIED
status-b2g18: fixed → verified
status-b2g18-v1.0.1: fixed → verified
You need to log in before you can comment on or make changes to this bug.