865161 - [Call log] Creating new contact/Adding to an existing contact is not working correctly

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[isabelrios]

Seen with Unagi, Ikura and Inari devices.
Ikura build id: 20130423004103
Unagi v1.0.1 build info:
Gecko-be0068c
Gaia-d5c25ac

PROCEDURE
**Have some contacts on the addressbook
**Have some entries in the call log, outgoing/incoming/missed calls from numbers not stored as contacts.
1. Tap on one of these entries.
2. Tap on 'Create as a new contact'/'Add to an existing contact'

EXPECTED
The contact details screen is shown in edit mode with the number pre-filled.

ACTUAL
The contact details screen is shown for a few seconds, but then another contact's details screen is shown on top.

Comment 1

[alberto.pastor]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9429

Pointer to Github pull-request

Comment 2

[Maria Angeles Oteo (:oteo)]

This bug is only affecting v1.0.1 branch, so the patch is only for this branch

Comment 4

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 742282 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/9429

r+

tried on the phone v1.0.1 and working, unfortuantely unit tests are failing in 1 case, and not related to the problem fixed here. 

Probably cause one of the uplifts, not merging by myself just to give some time to Alberto to fix the unit tests, anyway, not I'm not blocking on this, so if you want to merge go ahead, but I would prefer to have the unit test fixed.

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Taking into account the actual state of tests in v1.0.1 we will need to fix too many tests, not just the ones related to dialer.

In fact there is a PR with master-gaia-approval requested that didn't make it to the branch. And try to solve all the unit tests in this PR will take us so long.

I'll merge this bug to have the functionality working again.

Thanks folks!

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

 > I'll merge this bug to have the functionality working again.
> 
> Thanks folks!

I mean, please could you merge :) ?

Comment 7

[Alex Keybl [:akeybl]]

This needs to land asap to make the 5/10 deadline.

Comment 8

[John Ford [:jhford] CET/CEST Berlin Time]

v1.0.1: 2d500c0

Comment 9

[Andrew Overholt [:overholt]]

(In reply to comment #2)
> This bug is only affecting v1.0.1 branch, so the patch is only for this
> branch

(In reply to comment #8)
> v1.0.1: 2d500c0

-> RESOLVED FIXED :)

Comment 10

[Delphine Lebédel [:delphine - Use needinfo]]

Verified fixed on today's Inari, v1.0.1 Commercial RIL
Gaia   54dfb62735c81152eef74eb1768e2bf621c0a258
BuildID 20130513070209
Version 18.0