865173 - Localized strings are not showing up in the payments flow

Status: VERIFIED FIXED

(Marketplace Graveyard :: Payments/Refunds, defect, P3)

Description

[krupa raj[:krupa]]

Localized strings are not showing up in the payments flow in Stage. This was fixed for -dev in bug 854582. We need to fix this for stage as well

Comment 1

[Wil Clouser [:clouserw]]

Looks like Andy did that bug.  Seems like the fix should affect stage as much as it did -dev but I'm probably missing something.

Comment 2

[Kumar McMillan [:kumar]]

Which language is not showing localized strings? Can you provide an example of nonlocalized text?

It looks like the files are getting compiled just fine on stage via https://marketplace-dev.allizom.org/mozpay/media/updater.output.txt

[2013-04-25 03:45:36] Running update_locales
[2013-04-25 03:45:36] [localhost] running: cd /data/addons-dev/src/marketplace-dev.allizom.org-webpay/webpay && bin/compile-mo.sh locale
[2013-04-25 03:45:37] [localhost] finished: cd /data/addons-dev/src/marketplace-dev.allizom.org-webpay/webpay && bin/compile-mo.sh locale (0.231s)
[2013-04-25 03:45:37] Finished update_locales (0.231s)

Comment 3

[krupa raj[:krupa]]

This happens in -dev too

Example Strings: These strinsg don't show up in es when phone language=es

* Connecting to Persona
* Create PIN
* Confirm PIN
* Enter PIN
* Pins do not match
* Wrong Pin
* Payments complete
* Payments cancelled

Comment 4

[Kumar McMillan [:kumar]]

These look like recently added strings (except for the PIN ones). Wil, how complete is es?

Comment 5

[Wil Clouser [:clouserw]]

Inma did a pull request this morning but had a typo.  He's fixing it.

Comment 6

[Andy McKay]

These strings are now in the .pot, or have been changed, but I confirmed the changed strings are in the .pot file. Now we've got the script to keep translations up to date, I think we should be ok.

Comment 7

[krupa raj[:krupa]]

Strings currently localized @ https://github.com/mozilla/webpay/blob/master/locale/es/LC_MESSAGES/messages.po#L203 show up as expected.