865211 - Test failure "aController.window.PlacesStarButton is undefined" in /testBookmarks_AddAndRemoveBookmarkViaAwesomeBar/test1.js

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect, P1)

Description

[Andrei Eftimie]

Endurance test failure on Nightly OSX:
http://mozmill-ci.blargon7.com/#/endurance/report/49feb8c5f96a46e9037cffdde12c3670

Comment 1

[Andreea Matei [:AndreeaMatei]]

This is the changeset responsible, Daniela will provide a skip patch until we figure out what to use next:
http://hg.mozilla.org/mozilla-central/rev/1706d6e0514b

Comment 2

[Daniela Petrovici]

Attachment: skip patch v1.0

Skip patch.

Comment 3

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 741290 [details] [diff] [review]
skip patch v1.0

Review of attachment 741290 [details] [diff] [review]:
-----------------------------------------------------------------

Skipped:
http://hg.mozilla.org/qa/mozmill-tests/rev/d9e7ef22bc6d (default)

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Regression in our tests because of an intentional change in Firefox. Lets get this fixed quickly.

Comment 5

[Marco Bonardo [:mak]]

oops, the PlacesStarButton object has been replaced by BookmarksMenuButton, it now has a .status property with value BookmarksMenuButton.STATUS_UPDATING, BookmarksMenuButton.STATUS_STARRED or BookmarksMenuButton.STATUS_UNSTARRED

You may look at the browser chrome tests I changed in that changeset.

Comment 6

[Daniela Petrovici]

Attachment: patch v1.0

Changed the isBookmarkStarButtonReady method to use the new status property. 

Also changed the toolbars/locationBar getElement method since the ID of the star-button was changed to bookmarks-menu-button.

Reports are: 
Linux: http://mozmill-crowd.blargon7.com/#/endurance/report/49feb8c5f96a46e9037cffdde12efe17
MAC: http://mozmill-crowd.blargon7.com/#/endurance/report/49feb8c5f96a46e9037cffdde1303343
Windows: http://mozmill-crowd.blargon7.com/#/endurance/report/49feb8c5f96a46e9037cffdde133de25

Comment 7

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 741355 [details] [diff] [review]
patch v1.0

Review of attachment 741355 [details] [diff] [review]:
-----------------------------------------------------------------

Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/b3e4991141da (default)