865212 - [Homescreen] Add a test suite for dock and pagination bar

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Comment 1

[Cristian Rodriguez (:crdlc)]

Attachment: Patch v1

Minor improvements in dock test and add a new test suite for pagination bar module

Comment 2

[Cristian Rodriguez (:crdlc)]

Added a new test suite for dialog request in other file

Comment 3

[Cristian Rodriguez (:crdlc)]

Added new suite for BookmarkEditor object

Comment 4

[Cristian Rodriguez (:crdlc)]

Added new test suites for homescreen.js and bookmark objects

Comment 5

[Cristian Rodriguez (:crdlc)]

I guess that I can say that this bug has been completed. Right now, we can start reviewing the code, thanks Jose

Comment 6

[Jose Manuel Cantera]

I'm having problems running grid_test.js tests, please could you check,

thanks

Comment 7

[Cristian Rodriguez (:crdlc)]

If there is fails re-open this bug 867064

Comment 8

[Jose Manuel Cantera]

Comment on attachment 741298 [details]
Patch v1

tests up and running

thanks!

Comment 9

[Cristian Rodriguez (:crdlc)]

https://github.com/mozilla-b2g/gaia/commit/7474378b7559d5c30c3b080c09f3c237b5a12e69

Comment 10

[Julien Wajsberg [:julienw]]

The new tests don't run for me...

Comment 11

[Cristian Rodriguez (:crdlc)]

For me works fine, what problem do you have?

Comment 12

[Cristian Rodriguez (:crdlc)]

I have only one problem running all tests in my PC

x 1 of 2814 tests failed:

  1) [communications] Render contact "before each" hook:
     TypeError: Contacts.getTags is not a function

Comment 13

[Julien Wajsberg [:julienw]]

when running only the homescreen tests :

 ✖ 3 of 50 tests failed:

  1) [homescreen] pagbar.js > Pagination bar > Current page index: 3, total pages: 5 >:
     Error: TypeError: HomeState is null (http://homescreen.gaiamobile.org:8080/js/grid.js?time=1367492763080:694)
      at onerror (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4959)
  

  2) [homescreen] pagbar.js > Pagination bar > Adding a new page >:
     Error: expected false to be true
      at chaiAssert (http://test-agent.gaiamobile.org:8080/common/test/helper.js:30)
      at get (http://test-agent.gaiamobile.org:8080/common/vendor/chai/chai.js:374)
      at isTrue (http://test-agent.gaiamobile.org:8080/common/vendor/chai/chai.js:1367)
      at (anonymous) (http://homescreen.gaiamobile.org:8080/test/unit/pagbar_test.js:67)
      at wrapper (http://test-agent.gaiamobile.org:8080/common/test/mocha_generators.js:62)
      at run (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3709)
      at runTest (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4081)
      at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4127)
      at next (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4007)
      at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4016)
      at next (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3964)
      at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3984)
      at (anonymous) (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4932)
  

  3) [homescreen] pagbar.js > "after all" hook:
     Node was not found


However this works fine when launching only pagbar.js.

And indeed it works when launching all the tests, which is strange to me, because the various apps should be sandboxed...

Comment 14

[Cristian Rodriguez (:crdlc)]

I don't understand why it can happen:

1) All Gaia tests works fine
2) Running only pagbar.js works fine as well
3) Depending the order of unit tests of the homescreen, pagbar_test.js fails or not

Sorry but I don't have idea...

Comment 15

[Cristian Rodriguez (:crdlc)]

And the strangest issue is this [1], pagbar doesn't use neither grid nor HomeState, it is standalone, only require ('homescreen/js/pagbar.js'); and doesn't overwrite the body of the document...

[1]

1) [homescreen] pagbar.js > Pagination bar > Current page index: 3, total pages: 5 >:
     Error: TypeError: HomeState is null (http://homescreen.gaiamobile.org:8080/js/grid.js?time=1367492763080:694)
      at onerror (http://test-agent.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4959)

Comment 16

[Julien Wajsberg [:julienw]]

Yep, I'm quite sure the HomeState issue existed before your tests here, I already saw it. Probably it didn't happen always before because of timing issue, and it always happen now because there is a strange interaction between tests.

If the whole test is not failing then there is no urgency and I think I can try to take some time and see why this happens.