Recognize exacutables on WINNT in is_executable.

RESOLVED FIXED in mozilla23

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Jacek Caban, Assigned: Jacek Caban)

Tracking

unspecified
mozilla23
x86_64
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Assignee)

Description

5 years ago
Created attachment 741295 [details] [diff] [review]
fix

This fixes exacutable stripping on mingw build.
Attachment #741295 - Flags: review?(mh+mozilla)
Attachment #741295 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/c9f50b631b7d
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23

Comment 3

5 years ago
when i ran "$pymake installers" in the objdir, I got errors. when I bakout this patch, it can pass. any idea?

Comment 4

5 years ago
Created attachment 742307 [details]
error
(Assignee)

Comment 5

5 years ago
Created attachment 742317 [details] [diff] [review]
patch

Does the attached patch help?

Comment 6

5 years ago
(In reply to Jacek Caban from comment #5)
> Created attachment 742317 [details] [diff] [review]
> patch
> 
> Does the attached patch help?

no. same error
(Assignee)

Comment 7

5 years ago
I don't see how this could happen on MSVC build. PKG_SKIP_STRIP should always be set there (configure script sets it unconditionally for MSVC builds), so may_strip should return false and strip() should never be called. Could you verify that your autoconf.mk has PKG_SKIP_STRIP set?

Comment 8

5 years ago
Sorry for the bother. the "--enable-install-strip" are not commented out in my mozconfig file.
You need to log in before you can comment on or make changes to this bug.