Created attachment 741295 [details] [diff] [review] fix This fixes exacutable stripping on mingw build.
Attachment #741295 - Flags: review?(mh+mozilla)
Attachment #741295 - Flags: review?(mh+mozilla) → review+
Thanks for quick review. https://hg.mozilla.org/integration/mozilla-inbound/rev/c9f50b631b7d
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
when i ran "$pymake installers" in the objdir, I got errors. when I bakout this patch, it can pass. any idea?
(In reply to Jacek Caban from comment #5) > Created attachment 742317 [details] [diff] [review] > patch > > Does the attached patch help? no. same error
I don't see how this could happen on MSVC build. PKG_SKIP_STRIP should always be set there (configure script sets it unconditionally for MSVC builds), so may_strip should return false and strip() should never be called. Could you verify that your autoconf.mk has PKG_SKIP_STRIP set?
Sorry for the bother. the "--enable-install-strip" are not commented out in my mozconfig file.
You need to log in before you can comment on or make changes to this bug.