865219 - Shipit should record who reviewed a release

Status: RESOLVED FIXED

(Release Engineering :: Applications: Shipit, defect, P3)

Description

[Chris AtLee [:catlee]]

In addition to recording who submitted a release to shipit, it would be handy to know who reviewed it and marked it as ready.

Comment 1

[[e-mail] (:bhearsum)]

This would be pretty easy to do. Just need to:
* Add another field to the db (http://git.mozilla.org/?p=build/release-kickoff.git;a=blob;f=kickoff/model.py;h=9eaae9bfa5a5ddd295ccc543f172bc96b0c0ef4a;hb=HEAD#l12, plus adding a new migration version like http://git.mozilla.org/?p=build/release-kickoff.git;a=blob;f=migrate_repo/versions/003_Add_submitted_at.py;h=201a46a89d6c1faca358d17c1b747e0bb4891a02;hb=HEAD)
* Change the field when the release gets submitted (http://git.mozilla.org/?p=build/release-kickoff.git;a=blob;f=kickoff/views/releases.py;h=7cb74ce40676ddbc61fd01dd292e02d5d471794c;hb=HEAD#l118)
* Expose it in a couple of places (http://git.mozilla.org/?p=build/release-kickoff.git;a=blob;f=kickoff/templates/includes/releases_reviewed.html;h=934a08183a79490552af2d7f4cfc41df2513ac72;hb=HEAD, http://git.mozilla.org/?p=build/release-kickoff.git;a=blob;f=kickoff/templates/includes/releases_complete.html;h=56f0b02417f0c7f3ec6c036a2aab96a760cc1234;hb=HEAD)

We may want to reset the state of the field if a release goes from ready -> !ready.

Comment 2

[[e-mail] (:bhearsum)]

Mass component change for ship it bugs.

Comment 3

[[e-mail] (:bhearsum)]

This is probably fixed by bug 1140567.

Comment 4

[Rail Aliiev [:rail]]

(In reply to [e-mail] (:bhearsum) from comment #3)

This is probably fixed by bug 1140567.

Yes!