865222 - JSAutoCompartment should use MOZ_GUARD_OBJECT_NOTIFIER_PARAM

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Boris Zbarsky [:bzbarsky]]

I was looking at some code this morning that did:

    JSAutoCompartment(aCx, valueObj);

and then of course unpleasant things happened somewhere down the line...

Comment 1

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Attachment: Patch 1 (v1) - Add MOZ_GUARD_OBJECT_NOTIFIER_PARAM to JSAutoCompartment and JSAutoNullableCompartment

Comment 2

[Eric Faust [:efaust]]

Comment on attachment 8597549 [details] [diff] [review]
Patch 1 (v1) - Add MOZ_GUARD_OBJECT_NOTIFIER_PARAM to JSAutoCompartment and JSAutoNullableCompartment

My God. I've personally done this in patches. Thanks so much for fixing this footgun.

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0dd11177cdc4

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0dd11177cdc4