Refine animations in toolbar

RESOLVED FIXED in Firefox 23

Status

()

Firefox for Android
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: lucasr, Assigned: lucasr)

Tracking

unspecified
Firefox 23
All
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: ui-hackathon)

Attachments

(7 attachments)

(Assignee)

Description

5 years ago
There's a lot of small glitches when we animate the forward button and the lock icon. e.g. the title often overlaps with close/reader button while animating.

We should ensure things only move around when needed with the correct layout.
Things I am noticing are

* When loading a page from the awesomebar, the "stop" X appears before the url bar shrinks, which looks bad since the X is just sitting in the middle of the bar
* We seem to reanimate the lock transition, *no matter what*. So if I go to a page with a lock, and then go back, and then go forward, Firefox does the whole lock animation over, as though it forgot whether that site had a lock or not even though I was just there. 

Is there any way we can remember the URL bar's state so we only show the lock animation transition the *first time the page loads* in that session? I imagine that would fix a lot of the weirdness we're seeing with the forward / lock / page load animations on tablets.
(Assignee)

Comment 2

5 years ago
Created attachment 742448 [details] [diff] [review]
Slide tabs button all the way off screen
Attachment #742448 - Flags: review?(mark.finkle)
Attachment #742448 - Flags: review?(mark.finkle) → review+
(Assignee)

Comment 3

5 years ago
Created attachment 743133 [details] [diff] [review]
(1/4) Only animate tabs counter once tabs button is on screen
Attachment #743133 - Flags: review?(mark.finkle)
(Assignee)

Comment 4

5 years ago
Created attachment 743134 [details] [diff] [review]
(2/4) Remove unnecessary views from toolbar animation
Attachment #743134 - Flags: review?(mark.finkle)
(Assignee)

Comment 5

5 years ago
Created attachment 743135 [details] [diff] [review]
(3/4) Smoother fade-in animation when coming from awesomescreen
Attachment #743135 - Flags: review?(mark.finkle)
(Assignee)

Comment 6

5 years ago
Created attachment 743136 [details] [diff] [review]
(4/4) Hide stop/reader buttons immediately when entering awesomescreen
Attachment #743136 - Flags: review?(mark.finkle)
Attachment #743133 - Flags: review?(mark.finkle) → review+
Attachment #743134 - Flags: review?(mark.finkle) → review+
Attachment #743135 - Flags: review?(mark.finkle) → review+
Attachment #743136 - Flags: review?(mark.finkle) → review+
(Assignee)

Comment 7

5 years ago
Created attachment 743599 [details] [diff] [review]
(1/2) Rename mAnimateSiteSecurity to mSwitchingTabs
Attachment #743599 - Flags: review?(mark.finkle)
(Assignee)

Comment 8

5 years ago
Created attachment 743601 [details] [diff] [review]
(2/2) Don't animate forward button when switching tabs
Attachment #743601 - Flags: review?(mark.finkle)
Attachment #743599 - Flags: review?(mark.finkle) → review+
Attachment #743601 - Flags: review?(mark.finkle) → review+
(Assignee)

Comment 9

5 years ago
Pushed:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3f18ab3e32f2
https://hg.mozilla.org/integration/mozilla-inbound/rev/885e0fb3afca
https://hg.mozilla.org/integration/mozilla-inbound/rev/913ae89e272b
https://hg.mozilla.org/integration/mozilla-inbound/rev/6d323a2eef78
https://hg.mozilla.org/integration/mozilla-inbound/rev/3c956043cac3
https://hg.mozilla.org/integration/mozilla-inbound/rev/8c5e1ae70259
https://hg.mozilla.org/integration/mozilla-inbound/rev/eeabfd7af89a
https://hg.mozilla.org/mozilla-central/rev/3f18ab3e32f2
https://hg.mozilla.org/mozilla-central/rev/885e0fb3afca
https://hg.mozilla.org/mozilla-central/rev/913ae89e272b
https://hg.mozilla.org/mozilla-central/rev/6d323a2eef78
https://hg.mozilla.org/mozilla-central/rev/3c956043cac3
https://hg.mozilla.org/mozilla-central/rev/8c5e1ae70259
https://hg.mozilla.org/mozilla-central/rev/eeabfd7af89a
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 23
You need to log in before you can comment on or make changes to this bug.