86530 - Table containing iframes generated with document.write is laid-out wrongly

Status: RESOLVED FIXED

(Core :: Layout, defect, P4)

Description

[womble]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:0.9.1) Gecko/20010607
BuildID:    2001060703

PDABuzz forum pages include advert images inside iframes for which the HTML code
is generated using document.write() to randomise the image URLs used.  If
JavaScript is disabled, static HTML code is used instead, and it appears to be
identical aside from lack of randomisation of the URLs of the images.  However,
the page is rendered substantially differently when JavaScript is enabled.

Reproducible: Always
Steps to Reproduce:
1. Ensure that JavaScript is turned on.
2. Point the browser at the given URL (or any other PDABuzz discussion thread
page, if this one goes away).

Actual Results:  The adverts appear surrounded to the right of the links at the
left-hand side, with a lot of blank space around them, and the discussion is
only accessible by scrolling to the right.

Expected Results:  The adverts should appear in a column along with the links at
the left-hand side, and the discussion itself should be laid out within the
remaining width of the browser window.

Comment 1

[Johnny Stenback (:jst)]

Does the same thing happen if the iframes are written in the HTML file instead
of being document.written? If so, this belongs in the layout component.

Comment 2

[basic]

Confirmed on Build 2001061804 win32 on win98
when they are not document.written it doesn't happen.
This might have something to do with having lots of nested tables in the right
<td>. I tried downloading the page and removing some of the nested tables and it
fixes the problem at some point. Will need more investigation.

Comment 3

[basic]

found the cause. the page layout problem is due to 'nowrap' appearing on line 73
in the source. So does this belong to layout or dom?

Comment 4

[Johnny Stenback (:jst)]

[e-mail], thanks for debugging this!

Over to layout.

Comment 5

[rubydoo123]

the layout issue seems to be resolved, but the randamized content of the iframe 
seems to be frozen. I pulled out the content of the iframe into a separate test 
case and it randomized correctly. I nested it within two tables and it still 
worked. However, I did have to reload the page a few times for it to finally 
rotate like it rotates in IE.

Attaching reduced test case.

Comment 6

[rubydoo123]

Attachment: reduced test case of iframe

Comment 7

[Ben Hutchings]

I am the original reporter with a new email address. The problem no longer
occurs in version 0.9.5 (build 2001101117) on Windows 2000. This should
presumably be verified fixed and then closed?

Comment 8

[Kevin McCluskey (gone)]

Resolving as fixed based on Ben Hutchings last comment.