Closed
Bug 865390
Opened 12 years ago
Closed 12 years ago
MakeAPI client side broken
Categories
(Webmaker Graveyard :: MakeAPI, defect)
Webmaker Graveyard
MakeAPI
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mjschranz, Assigned: mjschranz)
Details
Attachments
(1 file)
In our efforts to fix the server side we acted too quickly and didn't properly check it client side.
Fix incoming.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #741461 -
Flags: review?(chris)
|
|
Assignee | |
Comment 2•12 years ago
|
||
Comment on attachment 741461 [details] [review]
https://github.com/mozilla/MakeAPI/pull/34
Wanted both of you this time to go over this.
Attachment #741461 -
Flags: review?(scott)
|
||
Comment 3•12 years ago
|
||
Comment on attachment 741461 [details] [review]
https://github.com/mozilla/MakeAPI/pull/34
Makes sense.
Attachment #741461 -
Flags: review?(scott) → review+
|
||
Comment 4•12 years ago
|
||
Comment on attachment 741461 [details] [review]
https://github.com/mozilla/MakeAPI/pull/34
Good for now. I'm going to rewrite this using the Strategy Pattern soon, hopefully we can avoid problems like this.
land plz!
Attachment #741461 -
Flags: review?(chris) → review+
|
|
Assignee | |
Comment 5•12 years ago
|
||
Staged on master: https://github.com/mozilla/MakeAPI/commit/1c27a46d955fbb3a5e1e722a930a1418bb9ab08d
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
||
Updated•12 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•