Closed
Bug 865402
Opened 13 years ago
Closed 13 years ago
Fix custom validation bug
Categories
(Webmaker Graveyard :: Login, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: sedge, Assigned: sedge)
Details
(Whiteboard: u=dev c=login p=1 s=2013w17)
Attachments
(1 file)
The validator was tested incorrectly, and throws an error due to incorrect syntax.
|
Assignee | |
Updated•13 years ago
|
Whiteboard: u=dev c=login p=1 s=2013w17
|
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #741467 -
Flags: review?(ross)
|
|
||
Comment 2•13 years ago
|
||
Comment on attachment 741467 [details] [review]
Pullr request for this patch
Made a couple of comments on the pull request to fix please
Attachment #741467 -
Flags: review?(ross) → review-
|
|
Assignee | |
Comment 3•13 years ago
|
||
Comment on attachment 741467 [details] [review]
Pullr request for this patch
Ready for review
Attachment #741467 -
Flags: review- → review?(ross)
|
|
||
Comment 4•13 years ago
|
||
Comment on attachment 741467 [details] [review]
Pullr request for this patch
Much better - thanks!
Attachment #741467 -
Flags: review?(ross) → review+
|
|
||
Comment 5•13 years ago
|
||
Merged to master - https://github.com/mozilla/login.webmaker.org/commit/890bbe2888ddb1a362b0246ea672c31ffc23c7e0
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•12 years ago
|
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in
before you can comment on or make changes to this bug.
Description
•