865452 - [AccessFu] Don't capture scripted mouse events

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Eitan Isaacson [:eeejay]]

Scripted mouse events should not be captured since they are not directly caused by the user's mouse or touch.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Don't capture scripted mouse events.

Comment 2

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 741517 [details] [diff] [review]
Don't capture scripted mouse events.

Review of attachment 741517 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. Not sure if you need a bug number in the commit message as well.

::: accessible/src/jsat/TouchAdapter.jsm
@@ +97,5 @@
>      if (Utils.MozBuildApp == 'browser' &&
>          aEvent.view.top instanceof Ci.nsIDOMChromeWindow)
>        return;
>  
> +    if (aEvent.mozInputSource == Ci.nsIDOMMouseEvent.MOZ_SOURCE_UNKNOWN)

Nit: Could this possibly be wrapped in a block statement. I realize that there are plenty of cases like that in the code base already, but it would be slightly less prone to bugs.

::: accessible/src/jsat/content-script.js
@@ +120,5 @@
>  
>        let x = Math.round((objX.value - docX.value) + objW.value / 2);
>        let y = Math.round((objY.value - docY.value) + objH.value / 2);
>  
> +      var node = aAccessible.DOMNode || aAccessible.parent.DOMNode;

Nit: Should probably use let instead of var for consistency.

@@ +122,5 @@
>        let y = Math.round((objY.value - docY.value) + objH.value / 2);
>  
> +      var node = aAccessible.DOMNode || aAccessible.parent.DOMNode;
> +
> +      var evt = content.document.createEvent("MouseEvents");

Perhaps this could be folded into a function, what do you think?

Comment 3

[Eitan Isaacson [:eeejay]]

Attachment: Bug 865452 - Don't capture scripted mouse events.

Comments addressed

Comment 4

[Eitan Isaacson [:eeejay]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/38cac63b52b3

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/38cac63b52b3