86548 - add bindings to help buttons for PSM

Status: VERIFIED FIXED

(Core Graveyard :: Security: UI, defect, P1)

Description

[Stephane Saux]

See the list of bindings with targets at:
http://www.mozilla.org/projects/security/pki/psm/pip_ui_elements.html
In certain cases may need to add buttons.

Comment 1

[Stephane Saux]

-> P1
as per today's meeting.
This bug depends on 46226.

Comment 2

[Stephane Saux]

version 2.0

Comment 3

[Stephane Saux]

*** Bug 86872 has been marked as a duplicate of this bug. ***

Comment 4

[Bob Lord]

Stephane, is it your intention to get changes made in mozilla0.9.2? Do we know
how many there are?  I'm wondering about setting the target to 2.0.

Comment 5

[Stephane Saux]

I think it would be good if RTM went out with these changes. That's why I left
it 2.0.  If it doesn't make it, this will go 2.1.  No assessment of exactly how
many dialogs need to be tweaked, but I'd bet around 5?

Comment 6

[Stephane Saux]

Mass reassigning target to 2.1

Comment 7

[Ian Oeschger (gone)]

TRying to reset target (so I can attach patch for dialogs with help buttons).

Comment 8

[Ian Oeschger (gone)]

Attachment: update to patch I sent around: works now for certManager

Comment 9

[Javier Delgadillo]

r=javi

Comment 10

[Brendan Eich [:brendan]]

I can rs= the patch, having skimmed it.  Cc'ing hewitt, who I would like to give
a better rs= or sr=, or (equally fine) to tell me it's all good and validate my
rubberstamp usage.

/be

Comment 11

[Bob Lord]

*** Bug 88245 has been marked as a duplicate of this bug. ***

Comment 12

[Bob Lord]

*** Bug 88246 has been marked as a duplicate of this bug. ***

Comment 13

[Stephane Saux]

We should remove the two dump() statements.
r=ssaux

Comment 14

[Joe Hewitt (gone)]

Some comments:

* in getSelectedTab, it might be better to use the selectedTab property of your
tabbox and compare its id, rather than doing a getElementById for all possible tabs.

* in several xul files, you have orient="horizontal" on buttons, which seems
unnecessary.

* I don't understand why you need to put style="width: 10ex" on all those
buttons.  The theme should define the size of those buttons.

* these files are missing type="application/x-javascript" on most of the script
tags.

Actually, the last 3 comments are not relevant to the changes you're making,
they're more general problems with the affected files.  I'll give an sr=hewitt
for this patch, but I suggest you address these other issues in the future.

Comment 15

[Javier Delgadillo]

Attachment: The patch that actually got checked into the trunk.

Comment 16

[clayton]

Marking PDT+.  No need for a=, good to go into the branch.

Comment 17

[Javier Delgadillo]

patch checked into branch.

Comment 18

[John Unruh]

Verified. Hewitt, please open another bug which addresses your comments from 
6/28.

Comment 19

[Stephane Saux]

I've already filed a bug addressing Hewitt's comments: bug 88328