Closed Bug 865503 Opened 7 years ago Closed 7 years ago

Remove unnecessary else-after-return from nsTableFrame::AncestorsHaveStyleHeight

Categories

(Core :: Layout: Tables, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla23

People

(Reporter: dholbert, Assigned: dholbert)

Details

Attachments

(1 file, 1 obsolete file)

I noticed an unnecessary else-after-return in nsTableFrame::AncestorsHaveStyleHeight.

Patch coming up.
Attached patch fix v1 (obsolete) — Splinter Review
This patch just drops the unnecessary 'else'.

[I initially was thinking we could drop this line entirely and just fall down to the existing final "return false", but that doesn't work because this code is inside of a "for" loop, which loops back around before hitting that final return statement.]
Attachment #741592 - Flags: review?(matspal)
Attached patch fix v2Splinter Review
Actually, we might as well just directly return the boolean condition, rather than checking the condition and returning true if it's true, false if it's false.
Attachment #741592 - Attachment is obsolete: true
Attachment #741592 - Flags: review?(matspal)
Attachment #741607 - Flags: review?(matspal)
Comment on attachment 741607 [details] [diff] [review]
fix v2

r=mats
Attachment #741607 - Flags: review?(matspal) → review+
https://hg.mozilla.org/mozilla-central/rev/de487abe67a2
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.