865526 - An error warning is issued to console (or to ~/.xsession-errors): Trying to position a sizeless window; caller should have called sizeToContent() or sizeTo().

Status: NEW

(Thunderbird :: General, defect)

Description

[ISHIKAWA, Chiaki]

Hi,

I moved this from the original (already closed) bug 75649.
That bug has a very different subject line and is misleading for this particular misuse of some functions.

How to reproduce.

Choose a message and click print preview from the context-menu (right click on the message and choose print preview.)

As soon as the very small "print preview" window (without any content) 
appears, I see the following message (in .xsession-errors under Gnome desktop under Debian GNU/Linux):

Trying to position a sizeless window; caller should have called sizeToContent() or sizeTo(). See bug 75649.

then a moment later, the window becomes larger to show the preview content (and I noticed that somehow the small window is again shown for a split second, but people who know the code can ascertain that such behavior will happen.),
and then I see the following two lines in ~/.xsesson-errors. Something is very fishy.:

Trying to position a sizeless window; caller should have called sizeToContent() or sizeTo(). See bug 75649.
ウィンドウ・マネージャーの警告: 0x3755d1b (印刷プ�) で指定したウィンドウ 0x3755b00 の WM_TRANSIENT_FOR が間違っています

The second line is a warning from the window manager (metacity of gnome desktop) and it is in Japanese: it translates roughly as

Warning from the Window manager: 0x3755d1b (Print P[review]; cut short due to the fixed size format display) has  specified (?) window 0x3755b00, but it has incorrect WM_TRASIENT_FOR.

The warning is terse and not for the ordinary users, and so its meaning is  obscure and I could not be sure of the translation, but 
I think it tries to tell the developers that usage of WM_TRANSIENT_FOR is wrong for this particular window associated with 0x3755d1b for "Print Preview".

Since I can reliably reproduce this every time by invoking "Print Preview", someone ought to look at this again.

On a hunch, I checked the operation of Firefox on the same OS (Debian GNU/Linux).
Firefox (v20.0) does not issue any such warning when I tried Print Preview.

So I think this is Thunderbird-specific code (maybe seamonkey, too?).

TIA

Comment 1

[Magnus Melin [:mkmelin] (away until Aug 10)]

Likely due to http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/components/printing/content/printPreviewProgress.xul#8

dialogOverlay.xul is obsolete...

Comment 2

[ISHIKAWA, Chiaki]

(In reply to Magnus Melin from comment #1)
> Likely due to
> http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/components/
> printing/content/printPreviewProgress.xul#8
> 
> dialogOverlay.xul is obsolete...

I have no clue what the remedy will be.
If dialogOverlay.xul is obsolete, what alternative will be available?

I wonder what method Firefox uses for (superficially siimlar looking) preview
process. It probably doesn't use this code quoted here.

TIA

Comment 3

[Magnus Melin [:mkmelin] (away until Aug 10)]

I'd think firefox uses the same, dunno why you don't see it. Maybe dump isn't enabled?

The remedy is to convert those windows that use dialogOverlay from being <window> to <dialog> and adapt code appropriately. (I removed some usage in bug 507622.)

Comment 4

[:aceman]

The file is in toolkit. Neil, would you agree with the approach described in comment 3?

Comment 5

[[e-mail]]

Both dialog.xml and dialogOverlay have the same warning, so switching from one to the other won't change anything in that respect.

http://mxr.mozilla.org/comm-central/search?string=sizeToContent%28%29+or+sizeTo%28%29

Comment 6

[ISHIKAWA, Chiaki]

(In reply to [e-mail] from comment #5)
> Both dialog.xml and dialogOverlay have the same warning, so switching from
> one to the other won't change anything in that respect.
> 
> http://mxr.mozilla.org/comm-central/
> search?string=sizeToContent%28%29+or+sizeTo%28%29

Hi,

I just noticed that this problematic output left in .xsession-errors under linux
is no longer there with locally build C-C thunderbird
version 32.0a1 (2014-06-01).

I will check if the current distributed version still prints this warning tomorrow.

TIA

Comment 7

[ISHIKAWA, Chiaki]

I still get this error/warning from locally compiled debug version of C-C TB when I invoked print preview function.

--DOCSHELL 0x7696ef0 == 15 [pid = 30383] [id = 16]
Trying to position a sizeless window; caller should have called sizeToContent() or sizeTo(). See bug 75649.
++DOCSHELL 0x7696ef0 == 16 [pid = 30383] [id = 18]