865551 - [Contacts] After switching language, phone/email/address labels won't be localized correctly

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

+++ This bug was initially created as a clone of Bug #854814 +++

== STR ==

1. Choose English as the current language
2. Enter Contact APP, create a new contact, the labels for phone/email/ address are all displayed in English.
3. Press Home button and enter Settings again, choose Chinese as the current language
4. Enter Contact APP again, check the language for phone/email/address labels

Expected result: 
  After switch the language, the labels for phone/email/address should be displayed in current language (Chinese).

Actual result:
 The labels are still in previous language (English).
 Click the label to see the label list, the label list are also in previous language (English).

*** For triage ***
Nominate as blocking: tef?, since a similar issue - Bug 860634 was marked as tef+.

Thanks.

Comment 2

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Fixed in Gaia master:
https://github.com/mozilla-b2g/gaia/commit/b23c5dbe6e6b53ba802fbb714667fc13e32f666c

v1-train: e26eadbc598bd09c80192016c1024a4a999a5361
v1.0.1: cf2d4136f0ebc66039637fdbeb72ed184dfbc0f2

Comment 3

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Hi Kaze,

Please be informed for this issue, we introduced some changes to have 
"data-l10n-id="#type_l10n_id#", where #type_l10n_id# is a template holder and will be replaced by some real value by JS code.

Please see an example here,
https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/contacts/index.html#L150

This may cause some warning messages when building Gaia, and I am thinking how to avoid this.

Maybe we can add some attribute to the element like "data-l10n-ignore=true" to this kind of template HTML?
I will prepare a patch if you think this is OK. 
Thank you.

Comment 4

[pallavi]

Verified and fixed on Inari.Changing the UI language reflects the Contact labels in the contact App.
Inari Build id:20130429070204
Environmental  Variables:
Kernel Date: Feb 21
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/45aa5ba0ed53
Gaia: cf2d4136f0ebc66039637fdbeb72ed184dfbc0f2

Verified and fixed on Leo.Changing the UI language reflects the Contact labels in the contact App.
Environmental Variables:
Leo Build ID: 20130426070204 Kernel Date: Mar 15
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/6c2493de1441
Gaia: c9046a7acef33328977840176ff5574720d2c74c

Comment 5

[Fabien Cazenave [:kaze]]

(In reply to Rudy Lu [:rudyl] from comment #3) 
> This may cause some warning messages when building Gaia, and I am thinking
> how to avoid this.

Oh, this is where these warnings came from. Good to know!