865612 - App is paid twice if user is receiving a phone call during purchase.

Status: RESOLVED FIXED

(Marketplace Graveyard :: Payments/Refunds, defect, P2)

Description

[Victor Carciu]

steps to reproduce:
1. Start the app purchase for a paid app
2. Enter PIN and press BUY button 
3. From another device, make a phone call during purchase process
4. Open again the app from step1 and buy it again

Expected results:
App is purchased only one time 

Actual result:
According to BANGO transactions list, app was paid twice

Comment 1

[Kumar McMillan [:kumar]]

To clarify: step #3 is the Bango screen with the blue spinner when it says "processing payment"

Comment 2

[Kumar McMillan [:kumar]]

I think what happened is the Bango payment completed but it could not redirect to the Mozilla success/error page because the Dialer app had focus. The redirect most likely was aborted. We would need server notifications (bug 866939) to make sure this can't happen.

Comment 3

[Andy McKay]

Can't tell if the log is coming through due to bug 884058 at this point.

Comment 4

[Andy McKay]

Now I'm blocked on making a payment by failing persona login on -dev. Sigh.

Comment 5

[Kumar McMillan [:kumar]]

There are a couple things that can happen in this scenario.

In the best case, Bango receives the payment POST. I verified that in this scenario our server event notice (bug 866939) does the right thing:

Jun 27 09:38:03 localhost6.localdomain: [] s.bango:INFO Received notification for billing_config_id '362130': bango_response_code: 'OK'; bango_response_message: 'Success'; bango_trans_id: '1083304275'; moz_transacti
on: 'webpay:7b13a2c0-b314-43b8-b78b-43c857e5bff2' :/data/www/payments-dev.allizom.org/solitude/lib/bango/resources/notification.py:36

The user will see "install failed" on Marketplace but the purchase button changes to "install" which they can click. They are not charged a second time.

There's a worse scenario (but unlikely one) where the phone call causes the Bango request to abort. I filed bug 887996 for that

Comment 6

[Andy McKay]

I think you are looking at the wrong log. We've got multiple things called notification and event. lib/bango/resources.py > NotificationResource is the success end point defined in webpay.

The server to server notification is lib/bango/resources.py > EventResource. The best place to look is in webpay. If this is being hit:

https://github.com/mozilla/webpay/blob/master/webpay/bango/views.py#L120

Then its hitting our server and we are good.

Comment 7

[Kumar McMillan [:kumar]]

whoops, good catch. I do not see event notices coming through at all, opened bug 888954

Comment 8

[Kumar McMillan [:kumar]]

To clarify a few things:
- comment #5 explains how the success redirect happens in the background if a phone call interrupts the payment
- if the final Bango pay request is aborted, bug 887996 will address it
- if the user taps the final pay button and the request doesn't appear to go through, re-submitting the payment will not cause a duplicate charge because of bug 845528
- I have not been able to reproduce the scenario where the payment goes through to Bango but the Mozilla redirect does not happen. If this theoretical case exists then we need Bango to address bug 888954 (server notices not working)

Comment 9

[Vikas Nanda]

Attachment: ezboot log

Comment 10

[Vikas Nanda]

Issue doesn't occur for region durango. User is not asked to purchase the app twice instead they can only install it or run/start the app.

Comment 11

[Vikas Nanda]

time: 10:40pm CEST
phone number:787633833
test app:pricetier 4

Comment 12

[Vikas Nanda]

Attachment: screenshot of pricetier 4

Comment 13

[Andy McKay]

This bug only affects the flow if the interruption is made at exactly the right point in the flow. I'm wondering if in comment 10 that occurred.

Comment 14

[Andy McKay]

Dropping to P2, because its not a blocker and not much can be done till bug 888954 is done.

Comment 15

[Andy McKay]

It looks like the notifications are working. This means we'll be updated when the notification comes through from Bango and know that the app is bought.

I think when a user clicks buy, they should get an error. I'm not sure how we can easily test this however, we might have to introduce a failure to be able to do this. Any ideas on how to test this?