error - DEPRECATION WARNING: archiveBookmarksFile is deprecated

VERIFIED FIXED in mozilla23

Status

Cloud Services
Firefox Sync: Backend
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: jimm, Assigned: raymondlee)

Tracking

unspecified
mozilla23
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa+])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
Got this today in the console.

[JavaScript Error: "DEPRECATION WARNING: archiveBookmarksFile is deprecated and will be removed in a future version
You may find more details about this deprecation at: https://bugzilla.mozilla.org/show_bug.cgi?id=857429
resource://gre/modules/PlacesUtils.jsm 1564 PU_archiveBookmarksFile
resource://services-sync/engines/bookmarks.js 351 _syncStart/<
resource://gre/modules/Task.jsm 192 TaskImpl_run
resource://gre/modules/Task.jsm 163 TaskImpl
resource://gre/modules/Task.jsm 135 Task_spawn
resource://services-sync/engines/bookmarks.js 374 _syncStart
resource://services-sync/engines.js 1341 SyncEngine__sync
resource://services-sync/engines/bookmarks.js 213 wrappedSync
resource://services-sync/engines/bookmarks.js 219 _sync
resource://services-sync/util.js 142 WrappedNotify
resource://services-sync/engines.js 520 Engine_sync
resource://services-sync/stages/enginesync.js 192 _syncEngine
resource://services-sync/stages/enginesync.js 147 sync
resource://services-sync/service.js 1193 onNotify
resource://services-sync/util.js 142 WrappedNotify
resource://services-sync/util.js 97 WrappedLock
resource://services-sync/service.js 1187 _lockedSync
resource://services-sync/service.js 1178 sync/<
resource://services-sync/util.js 71 WrappedCatch
resource://services-sync/service.js 1166 sync
null 0 null
" {file: "resource://gre/modules/Deprecated.jsm" line: 79}]
Depends on: 855638
Pretty sure this isn't Metro-specific.
Component: Sync → Firefox Sync: Backend
OS: Windows 8 Metro → All
Product: Firefox for Metro → Mozilla Services
Hardware: x86_64 → All
Version: Trunk → unspecified
(Assignee)

Updated

5 years ago
Assignee: nobody → raymond
(Assignee)

Comment 2

5 years ago
Created attachment 741950 [details] [diff] [review]
v1
Attachment #741950 - Flags: review?(rnewman)
Attachment #741950 - Flags: review?(rnewman) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
Comment on attachment 742210 [details] [diff] [review]
v2

Review of attachment 742210 [details] [diff] [review]:
-----------------------------------------------------------------

I don't think Try will exercise this code. Much of the Sync UI is manually tested. Will need a QA pass before it hits channels.
Attachment #742210 - Flags: review+
(Assignee)

Comment 6

5 years ago
(In reply to Richard Newman [:rnewman] from comment #5)
> Comment on attachment 742210 [details] [diff] [review]
> v2
> 
> Review of attachment 742210 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I don't think Try will exercise this code. Much of the Sync UI is manually
> tested. Will need a QA pass before it hits channels.

What is the procedure to get someone to QA this patch?
Land in services-central (I'm happy to do so) and then the magic will happen :)
Whiteboard: [qa+]
(Assignee)

Comment 8

5 years ago
(In reply to Richard Newman [:rnewman] from comment #7)
> Land in services-central (I'm happy to do so) and then the magic will happen
> :)

That would be great if you can do that.  Thanks!
OK, just to make myself feel better.
I duplicated this issue on Win8 + Nightly + new sync account.
And duplicated again on Linux + Nightly + new sync account.
I am thinking I can do this with an old account that is cleared through AP?
https://hg.mozilla.org/mozilla-central/rev/c5224bbcf40b
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
I will verify this as soon as I can.
Having DB issues against accounts in Production, so hard to getting any sync work done...
Sync happening again in Prod, so I will verify this issue this week...
OK. Picking up where I left off....let's see if my new accounts are working...
OK. So creating new Sync accounts with Nightly, I was no longer able to get this error.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.