865643 - error - DEPRECATION WARNING: archiveBookmarksFile is deprecated

Status: VERIFIED FIXED

(Firefox :: Sync, defect)

Description

[Jim Mathies [:jimm]]

Got this today in the console.

[JavaScript Error: "DEPRECATION WARNING: archiveBookmarksFile is deprecated and will be removed in a future version
You may find more details about this deprecation at: https://bugzilla.mozilla.org/show_bug.cgi?id=857429
resource://gre/modules/PlacesUtils.jsm 1564 PU_archiveBookmarksFile
resource://services-sync/engines/bookmarks.js 351 _syncStart/<
resource://gre/modules/Task.jsm 192 TaskImpl_run
resource://gre/modules/Task.jsm 163 TaskImpl
resource://gre/modules/Task.jsm 135 Task_spawn
resource://services-sync/engines/bookmarks.js 374 _syncStart
resource://services-sync/engines.js 1341 SyncEngine__sync
resource://services-sync/engines/bookmarks.js 213 wrappedSync
resource://services-sync/engines/bookmarks.js 219 _sync
resource://services-sync/util.js 142 WrappedNotify
resource://services-sync/engines.js 520 Engine_sync
resource://services-sync/stages/enginesync.js 192 _syncEngine
resource://services-sync/stages/enginesync.js 147 sync
resource://services-sync/service.js 1193 onNotify
resource://services-sync/util.js 142 WrappedNotify
resource://services-sync/util.js 97 WrappedLock
resource://services-sync/service.js 1187 _lockedSync
resource://services-sync/service.js 1178 sync/<
resource://services-sync/util.js 71 WrappedCatch
resource://services-sync/service.js 1166 sync
null 0 null
" {file: "resource://gre/modules/Deprecated.jsm" line: 79}]

Comment 1

[Richard Newman [:rnewman]]

Pretty sure this isn't Metro-specific.

Comment 2

[Raymond Lee [:raymondlee]]

Attachment: v1

Comment 3

[Raymond Lee [:raymondlee]]

Attachment: v2

Passed try
https://tbpl.mozilla.org/?tree=Try&rev=faf693e77735

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c5224bbcf40b

Comment 5

[Richard Newman [:rnewman]]

Comment on attachment 742210 [details] [diff] [review]
v2

Review of attachment 742210 [details] [diff] [review]:
-----------------------------------------------------------------

I don't think Try will exercise this code. Much of the Sync UI is manually tested. Will need a QA pass before it hits channels.

Comment 6

[Raymond Lee [:raymondlee]]

(In reply to Richard Newman [:rnewman] from comment #5)
> Comment on attachment 742210 [details] [diff] [review]
> v2
> 
> Review of attachment 742210 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I don't think Try will exercise this code. Much of the Sync UI is manually
> tested. Will need a QA pass before it hits channels.

What is the procedure to get someone to QA this patch?

Comment 7

[Richard Newman [:rnewman]]

Land in services-central (I'm happy to do so) and then the magic will happen :)

Comment 8

[Raymond Lee [:raymondlee]]

(In reply to Richard Newman [:rnewman] from comment #7)
> Land in services-central (I'm happy to do so) and then the magic will happen
> :)

That would be great if you can do that.  Thanks!

Comment 9

[James Bonacci [:jbonacci]]

OK, just to make myself feel better.
I duplicated this issue on Win8 + Nightly + new sync account.

Comment 10

[James Bonacci [:jbonacci]]

And duplicated again on Linux + Nightly + new sync account.
I am thinking I can do this with an old account that is cleared through AP?

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c5224bbcf40b

Comment 12

[James Bonacci [:jbonacci]]

I will verify this as soon as I can.
Having DB issues against accounts in Production, so hard to getting any sync work done...

Comment 13

[James Bonacci [:jbonacci]]

Sync happening again in Prod, so I will verify this issue this week...

Comment 14

[James Bonacci [:jbonacci]]

OK. Picking up where I left off....let's see if my new accounts are working...

Comment 15

[James Bonacci [:jbonacci]]

OK. So creating new Sync accounts with Nightly, I was no longer able to get this error.