Closed Bug 865680 Opened 10 years ago Closed 10 years ago

devtools.gcli.allowSet is in firefox.js twice

Categories

(DevTools Graveyard :: Graphic Commandline and Toolbar, defect)

Product:
DevTools Graveyard
Component:
Graphic Commandline and Toolbar
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 23

People

(Reporter: miker, Assigned: diogopontual)

Details

(Whiteboard: [good-first-bug][lang=js][mentor=mratcliffe])

Attachments

(1 file)

A patch to remove the second entry.
1.11 KB, patch
miker
: review+
Details | Diff | Splinter Review 
devtools.gcli.allowSet is in firefox.js twice ... one of them should be removed.
Assignee: nobody → diogopontual
Status: NEW → ASSIGNED
Removes the second line. The second one was choose because it is inert.
Attachment #742362 - Flags: review?(mratcliffe)
Comment on attachment 742362 [details] [diff] [review]
A patch to remove the second entry.

Review of attachment 742362 [details] [diff] [review]:
-----------------------------------------------------------------

Perfect, r+.
Attachment #742362 - Flags: review?(mratcliffe) → review+
Whiteboard: [good-first-bug][lang=js][mentor=mratcliffe] → [good-first-bug][lang=js][mentor=mratcliffe][land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/a00c50676287

woo!
Whiteboard: [good-first-bug][lang=js][mentor=mratcliffe][land-in-fx-team] → [good-first-bug][lang=js][mentor=mratcliffe][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/a00c50676287
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [good-first-bug][lang=js][mentor=mratcliffe][fixed-in-fx-team] → [good-first-bug][lang=js][mentor=mratcliffe]
Target Milestone: --- → Firefox 23
Product: Firefox → DevTools
Product: DevTools → DevTools Graveyard
You need to log in before you can comment on or make changes to this bug.